1317413 - Using Network Throttling with Network Inspector incorrectly show page elements loading twice

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Rubén]

Attachment: Screenshot_2016-11-14_19-23-46.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161114043454

Steps to reproduce:

I opened the Network Inspector > Clicked on the "Responsive Design Mode" button > Clicked "No throttling" > in the drop-down menu i selected "Regular 4G / LTE".

With both the Network Inspector open and the Responsive Design mode / Network Throttling set to throttle at "Regular 4G / LTE" speed, I then proceeded to open the webpage: https://www.bonnieradvocaten.nl/ 



Actual results:

The web-page https://www.bonnieradvocaten.nl loaded, but, according to the Network Inspector, every element  of the page (HTML, CSS, JS Images etc...) including the initial HTML was shown to be loaded twice.

I checked the server log for https://www.bonnieradvocaten.nl/ and the browser does not actually requests / fetches the elements (files) for the website twice. 

So Network Inspectors shows everything being loaded twice when it's not being fetched/loaded twice but just once. 

I'm including a screenshot of the Network Inspector so you can see what i'm writing about. 


Expected results:

When Network Throttling is used and the Network Inspector is simultaneously used  to measure performance. Every element of the web-page that is loaded once should correctly appear as only loaded once (and not two times).

Comment 1

[Rubén]

I would like to add this bugs occurs when using Firefox 52 as well as with Firefox 53. 

Furthermore I've reproduced this problem  using Ubuntu 16.10 and Windows 10; the problem occurs using Firefox on both platforms. 

If need be, i can provided anonymized excerpt of server-log showing Firefox requesting elements / files.

Comment 2

[Rubén]

I'm not sure whether to select: "Component: Developer Tools: Responsive Design Mode" or "Component: Net-monitor"

Comment 3

[Loic]

The issue appeared after bug 1283453.

Comment 4

[Rubén]

@Loic
I Gather it you are able to replicate this bug. If so, then shouldn't its status be set to "New" since it is confirmed?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the report, I can reproduce the issue!

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1317413 - Separate net monitor messages by RDP prefix.

In RDM, we use one net monitor RDP connection to set throttling values from the
UI and the toolbox uses a second connection to display requests.  When passing
data across processes, we need to include the RDP connection prefix in the name
to ensure it's routed properly to the right RDP connection.

Review commit: https://reviewboard.mozilla.org/r/93872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93872/

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8805387e23f8c1b5436dc3e9ffa39c3e6980203

Comment 8

[Tom Tromey :tromey]

Comment on attachment 8811993 [details]
Bug 1317413 - Separate net monitor messages by RDP prefix.

https://reviewboard.mozilla.org/r/93872/#review94184

Thank you.  This looks good.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8811993 [details]
Bug 1317413 - Separate net monitor messages by RDP prefix.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93872/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cb6ae537463
Separate net monitor messages by RDP prefix. r=tromey

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4cb6ae537463

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8811993 [details]
Bug 1317413 - Separate net monitor messages by RDP prefix.

Approval Request Comment
[Feature/regressing bug #]: Bug 1283453, though this just exposed an underlying problem
[User impact if declined]: Network monitor data in DevTools will be incorrectly reported twice for each request
[Describe test coverage new/current, TreeHerder]: Manual testing, landed in m-c
[Risks and why]: Low, only affect DevTools UI
[String/UUID change made/needed]: None

Comment 13

[Julien Cristau [:jcristau] (back April 22)]

tracking as new regression in 52.  fixed in 53, so not tracking.

Comment 14

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8811993 [details]
Bug 1317413 - Separate net monitor messages by RDP prefix.

devtools rdm fix for aurora52

Comment 15

[Carsten Book [:Tomcat]]

needs rebasing for aurora

grafting 376581:4cb6ae537463 "Bug 1317413 - Separate net monitor messages by RDP prefix. r=tromey"
merging devtools/shared/webconsole/network-monitor.js
warning: conflicts while merging devtools/shared/webconsole/network-monitor.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bafd3cf3970490e029351e6befa56667f568f85f

Comment 17

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 52.0a1 (2016-11-14) (64-bit) on Windows 7 , 64 Bit !

This bug's fix is now verified with latest Nightly and Aurora

Build    ID  :      20161214030231
User  Agent  :      Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 

Build    ID  :      20161214004021
User  Agent  :      Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161214]