1317423 - Move the WebConsoleConnectionProxy into it's own module

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Brian Grinstead [:bgrins]]

This will make it easier to load the frontend in a tab without needing to de-chrome everything (including WebConsoleFrame)

See https://github.com/jasonLaster/console.html/

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1317423 - Move WebConsoleConnectionProxy into its own module;

Review commit: https://reviewboard.mozilla.org/r/92928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92928/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1317423 - Remove unused declarations after move;

Review commit: https://reviewboard.mozilla.org/r/92930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92930/

Comment 3

[Brian Grinstead [:bgrins]]

Let's see what try thinks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a19c1e7d17f3bbb4e3e224a514ea9e7672dc6cf

Comment 4

[Brian Grinstead [:bgrins]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d5dae90769e50393fce6d4e1ac20aee3ee5607f

Comment 5

[Jason Laster [:jlast]]

Comment on attachment 8810641 [details]
Bug 1317423 - Move WebConsoleConnectionProxy into its own module;

Looks good!

Comment 6

[Jason Laster [:jlast]]

Comment on attachment 8810642 [details]
Bug 1317423 - Remove unused declarations after move;

Looks good. 

That's a lot of red!

Comment 7

[Brian Grinstead [:bgrins]]

Latest try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0ea6c87071670650fcf8c192b9720c63bd0d57a

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8810641 [details]
Bug 1317423 - Move WebConsoleConnectionProxy into its own module;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92928/diff/1-2/

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8810642 [details]
Bug 1317423 - Remove unused declarations after move;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92930/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93cbee4c2c35
Move WebConsoleConnectionProxy into its own module;r=jlast
https://hg.mozilla.org/integration/mozilla-inbound/rev/3500909e9408
Remove unused declarations after move;r=jlast

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93cbee4c2c35
https://hg.mozilla.org/mozilla-central/rev/3500909e9408