Closed Bug 1317423 Opened 3 years ago Closed 3 years ago

Move the WebConsoleConnectionProxy into it's own module

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

Details

(Whiteboard: console-in-tab)

Attachments

(2 files)

This will make it easier to load the frontend in a tab without needing to de-chrome everything (including WebConsoleFrame)

See https://github.com/jasonLaster/console.html/
Comment on attachment 8810641 [details]
Bug 1317423 - Move WebConsoleConnectionProxy into its own module;

Looks good!
Attachment #8810641 - Flags: review?(jlaster) → review+
Comment on attachment 8810642 [details]
Bug 1317423 - Remove unused declarations after move;

Looks good. 

That's a lot of red!
Attachment #8810642 - Flags: review?(jlaster) → review+
Latest try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0ea6c87071670650fcf8c192b9720c63bd0d57a
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8810641 - Flags: review?(jlaster) → review+
Attachment #8810642 - Flags: review?(jlaster) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93cbee4c2c35
Move WebConsoleConnectionProxy into its own module;r=jlast
https://hg.mozilla.org/integration/mozilla-inbound/rev/3500909e9408
Remove unused declarations after move;r=jlast
https://hg.mozilla.org/mozilla-central/rev/93cbee4c2c35
https://hg.mozilla.org/mozilla-central/rev/3500909e9408
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.