1317462 - Remove deprecated and unused capabilities from Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andreas, maybe you accidentally introduced this by bug 1217988? I don't see a reason why we have to transfer the version property twice.

Comment 1

[Andreas Tolfsen ❲:ato❳]

The browserVersion is the mandated WebDriver capability.  `version` is scheduled for removal, but we need to update any code using it first.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Remove version capability from Marionette;

Review commit: https://reviewboard.mozilla.org/r/92934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92934/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Remove XULappId capability from Marionette;

Review commit: https://reviewboard.mozilla.org/r/92936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92936/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Add test for processId capability;

Review commit: https://reviewboard.mozilla.org/r/92938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92938/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Remove appBuildId capability from Marionette;

Review commit: https://reviewboard.mozilla.org/r/92940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92940/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Remove platform capability from Marionette;

Review commit: https://reviewboard.mozilla.org/r/92942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92942/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317462 - Remove screenshot capabilities from Marionette;

Review commit: https://reviewboard.mozilla.org/r/92944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92944/

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

https://reviewboard.mozilla.org/r/92938/#review92968

::: testing/marionette/harness/marionette/runner/mixins/reporting.py:143
(Diff revision 1)
>          date_format = '%d %b %Y %H:%M:%S'
>          version = {}
>  
>          if self.capabilities:
> +            with self.using_context("chrome"):
> +                appinfo = self.execute_script("return Service.appinfo")

This file is gone soon via bug 1316707

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

https://reviewboard.mozilla.org/r/92940/#review92972

::: testing/marionette/harness/marionette/tests/unit/test_capabilities.py
(Diff revision 1)
>          self.assertEqual(self.caps["platform"], self.caps["platformName"].upper())
>  
> -    def test_extensions(self):
> -        self.assertIn("appBuildId", self.caps)
> -
> -        self.assertEqual(self.caps["appBuildId"], self.appinfo["appBuildID"])

We should leave this method in to test for the processId.

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

https://reviewboard.mozilla.org/r/92940/#review92972

> We should leave this method in to test for the processId.

Fixed in new patch.

Comment 11

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

https://reviewboard.mozilla.org/r/92938/#review92968

> This file is gone soon via bug 1316707

Thanks for the head’s up, but I don’t believe this is an issue.  Will be resolved during conflict resolution at rebase.

Comment 12

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810650 [details]
Bug 1317462 - Remove version capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92934/diff/1-2/

Comment 13

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810651 [details]
Bug 1317462 - Remove XULappId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92936/diff/1-2/

Comment 14

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92940/diff/1-2/

Comment 15

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92942/diff/1-2/

Comment 16

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92944/diff/1-2/

Comment 17

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92938/diff/1-2/

Comment 18

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810650 [details]
Bug 1317462 - Remove version capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92934/diff/2-3/

Comment 19

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810651 [details]
Bug 1317462 - Remove XULappId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92936/diff/2-3/

Comment 20

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92940/diff/2-3/

Comment 21

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92942/diff/2-3/

Comment 22

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92944/diff/2-3/

Comment 23

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92938/diff/2-3/

Comment 24

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92942/diff/3-4/

Comment 25

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92944/diff/3-4/

Comment 26

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92938/diff/3-4/

Comment 27

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810650 [details]
Bug 1317462 - Remove version capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92934/diff/3-4/

Comment 28

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810651 [details]
Bug 1317462 - Remove XULappId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92936/diff/3-4/

Comment 29

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92940/diff/3-4/

Comment 30

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92942/diff/4-5/

Comment 31

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92944/diff/4-5/

Comment 32

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92938/diff/4-5/

Comment 33

[David Burns :automatedtester]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

https://reviewboard.mozilla.org/r/92944/#review93852

Comment 34

[David Burns :automatedtester]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

https://reviewboard.mozilla.org/r/92940/#review93854

Comment 35

[David Burns :automatedtester]

Comment on attachment 8810651 [details]
Bug 1317462 - Remove XULappId capability from Marionette;

https://reviewboard.mozilla.org/r/92936/#review93856

Comment 36

[David Burns :automatedtester]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

https://reviewboard.mozilla.org/r/92938/#review93858

Comment 37

[David Burns :automatedtester]

Comment on attachment 8810650 [details]
Bug 1317462 - Remove version capability from Marionette;

https://reviewboard.mozilla.org/r/92934/#review94036

Comment 38

[David Burns :automatedtester]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

https://reviewboard.mozilla.org/r/92942/#review94038

Comment 39

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810650 [details]
Bug 1317462 - Remove version capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92934/diff/4-5/

Comment 40

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810651 [details]
Bug 1317462 - Remove XULappId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92936/diff/4-5/

Comment 41

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810653 [details]
Bug 1317462 - Remove appBuildId capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92940/diff/4-5/

Comment 42

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810654 [details]
Bug 1317462 - Remove platform capability from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92942/diff/5-6/

Comment 43

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810655 [details]
Bug 1317462 - Remove screenshot capabilities from Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92944/diff/5-6/

Comment 44

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810652 [details]
Bug 1317462 - Add test for processId capability;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92938/diff/5-6/

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46f4cea2b2d
Remove version capability from Marionette; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/317523c7dd69
Remove XULappId capability from Marionette; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/4cd9a4f42f35
Remove appBuildId capability from Marionette; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/6c00a7b80b3c
Remove platform capability from Marionette; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/e718e037a6c5
Remove screenshot capabilities from Marionette; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/0e1745003c29
Add test for processId capability; r=automatedtester

Comment 46

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c46f4cea2b2d
https://hg.mozilla.org/mozilla-central/rev/317523c7dd69
https://hg.mozilla.org/mozilla-central/rev/4cd9a4f42f35
https://hg.mozilla.org/mozilla-central/rev/6c00a7b80b3c
https://hg.mozilla.org/mozilla-central/rev/e718e037a6c5
https://hg.mozilla.org/mozilla-central/rev/0e1745003c29

Comment 47

[Andreas Tolfsen ❲:ato❳]

Sheriffs: Uplift please, as dependency to uplifting bug 1103196 (will upload patches soon).  Test-only, as Marionette is behind flag.

Comment 48

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/191d4889fc84
https://hg.mozilla.org/releases/mozilla-aurora/rev/735d9cd1eb17
https://hg.mozilla.org/releases/mozilla-aurora/rev/b19a90e15e88
https://hg.mozilla.org/releases/mozilla-aurora/rev/3dd987552789
https://hg.mozilla.org/releases/mozilla-aurora/rev/a352f96c3acb
https://hg.mozilla.org/releases/mozilla-aurora/rev/5dc1f6e2e083

Comment 49

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andreas Tolfsen ‹:ato› from comment #47)
> Sheriffs: Uplift please, as dependency to uplifting bug 1103196 (will upload
> patches soon).  Test-only, as Marionette is behind flag.

When you request uplifts please also make sure that known regressions also gets uplifted. This didn't happen in this case. Thanks. So I will do so now on bug 1319692.