1317580 - Add Deep Linking into FxA Views and Prefill Forms

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect, P3)

Description

[Vijay Budhram]

This is a feature request to add additional deep linking capabilities into FxiOS, in support of Firefox accounts.

Specifically, we should add the capability to directly launch into the FxA Sign-in view controller and prefill the login form with the passed email/code. We should also be able to reuse the existing deep linking scheme `firefox://`.

The extended scheme could look like below.

firefox://fxa=signin

The user is taken directly to the FxA Sign-in page. If param email/code is passed, then the email field on the page will be prefilled. Ex. firefox://fxa=signin&email=[e-mail]&code=coder. After the page has been loaded, we could inject the javascript needed to fill out these input fields.

firefox://fxa=signup

The user is taken directly to the FxA Sign-up page and email field is prefilled. Ex. firefox://fxa=signup&email=[e-mail]

In the event of an error while navigating or filling out the page, the current default action will be taken, which is to open the app.

Adding these capabilities will allow FxA to reduce the friction for signing up and signing in users.

Thoughts?

Comment 1

[Stephan Leroux [:sleroux]]

I think having the deep linking/auto filling of the FxA sign in form will be _way_ better than what we have now. As far as the schemes goes, I think it would work alright as you've listed. James has worked more on the schemes we currently support so I've CC'ed him for input.

Comment 2

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2249

Comment 3

[Aaron Train [:aaronmt]]

re lingering PR

Comment 4

[Stephan Leroux [:sleroux]]

Let's chat about this in triage today. I think we should put this into an upcoming release.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Question about the code: https://github.com/mozilla-mobile/firefox-ios/pull/2249/files#r92212536

Comment 6

[Farhan Patel [:farhan]]

I've left comments on the PR.

Comment 7

[Vijay Budhram]

PR updated and merged. Thanks guys!

Comment 8

[Stephan Leroux [:sleroux]]

master 54c89aa48812c35a5b6ffb32243bce544764f2cf

Comment 9

[Stephan Leroux [:sleroux]]

v6.x 767975f60dd5bed0db4873b1775d882d0b184d52

Comment 10

[Stephan Leroux [:sleroux]]

Attachment: PR: https://github.com/mozilla-mobile/firefox-ios/pull/2311

Adds a feature flag to disable this code path for the upcoming 6.0 release.

Comment 11

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8825160 [details] [diff] [review]
PR: https://github.com/mozilla-mobile/firefox-ios/pull/2311

https://github.com/mozilla-mobile/firefox-ios/pull/2311

Comment 12

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8825160 [details] [diff] [review]
PR: https://github.com/mozilla-mobile/firefox-ios/pull/2311

https://github.com/mozilla-mobile/firefox-ios/pull/2311

Comment 13

[Stephan Leroux [:sleroux]]

Feature flag patch

master 9fb8dfcf4377271da5ec8f5ab8bb2a24c87024df
v6.x 593fe136d05807f502394732fd61659409db0fcd

Comment 14

[Shane Tomlinson [:stomlinson]]

Re-opening this issue - the original patch was backed out and we have a new scheme!

The new deep-link will be:

firefox://fxa-signin?signin=<token>

When opening FxA, the signin query parameter should be propagated as a query parameter to FxA.

:rfeeley - You mentioned to me that you have presented your designs to the Fx for iOS UX folks, 
can you present them to :sleroux about where in the onboarding flow FxA should be opened with 
this deeplink?

Comment 15

[Ryan Kelly [:rfkelly]]

Since I don't see it noted explicitly here, I want to note that we intend to use this "deferred deeplinking" via adjust, as documented here:

  https://docs.adjust.com/en/deeplinking/#deferred-deeplinking

End-to-end, the idea would be that:

  * On their desktop machine, the user e.g. sends themselves an SMS to install Firefox on their mobile
  * The SMS contains a link like https://app.adjust.com/2uo1qc?deep_link=firefox://fxa-signin?signin=<token> where the token is specific to their account
  * Via the magic of adjust, they install Firefox on their mobile and it triggers opening of the provided deeplink
  * Firefox opens into whatever onboarding flow that :rfeeley is working on here, and they see their account details pre-filled in the signin screen

Comment 16

[Ryan Kelly [:rfkelly]]

(Using the whiteboard tag to link this into the FxA engineering waffleboard for tracking on our side as well; please let me know if this messes up any of your own uses of that field)

Comment 17

[Ryan Feeley [:rfeeley]]

Absolutely. Here is the link for Sleroux that shows the regular onboarding flow, on top of the proposed deep linked flow. https://mozilla.invisionapp.com/share/JABACOA4S#/228780472_Default

Robin tells me that there are changes being made to the onboarding flow. Let’s coordinate!

Comment 18

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2691

This PR updates FxA deep linking to use the new schema defined in https://bugzilla.mozilla.org/show_bug.cgi?id=1356386. It also removes the code that was prefilling email and access code from the app. Form filling will be performed from FxA via the passed signin query param.

Comment 19

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/bbe4956d918b25e58f14a814e19bf6b9ce6723db

Comment 20

[Vijay Budhram]

Attachment: Pull Request

Forgot to add test file to project. Also added a couple minor tweaks from your last review.

Comment 21

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/19e2316c94118adabd694e14647eda735e9cc167

Comment 22

[Vijay Budhram]

Attachment: Set flag to enabled FxA Deep linking in release channel