Closed Bug 1317587 Opened 3 years ago Closed 3 years ago

Scheduler will happily start a new sync even after shutdown has commenced.

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

If the scheduler's timer fires after shutdown has commenced we will still attempt to start syncing. This seems dumb.
Assignee: nobody → markh
Status: NEW → ASSIGNED
Comment on attachment 8810731 [details]
Bug 1317587 - don't start scheduled sync after shutdown.

https://reviewboard.mozilla.org/r/93048/#review93148

::: services/sync/modules/policies.js:408
(Diff revision 1)
>  
> +    try {
> +      Async.checkAppReady()
> +    } catch (ex) {
> +      if (Async.isShutdownException(ex)) {
> +        this._log.debug("Not initiating sync: app is shutting down");

Maybe put this function in async.js, call it `isAppReady`, and have it transform the exception into a bool?
Attachment #8810731 - Flags: review?(rnewman) → review+
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/b84a197304d6
don't start scheduled sync after shutdown. r=rnewman
https://hg.mozilla.org/mozilla-central/rev/b84a197304d6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.