Closed Bug 1317592 Opened 3 years ago Closed 3 years ago

Sync will continue trying to sync engines after shutdown

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: markh, Unassigned)

Details

Attachments

(1 file)

If there's a shutdown error syncing one engine, all other engines are still synced, but all still fail in various ungraceful ways due to the shutdown error, which may do bad things (eg, take everything out of the tracker and re-add them all, hopefully completing before the process finally dies).

It seems safer and generally better to not both trying to start any other engines after a shutdown.
Comment on attachment 8810718 [details]
Bug 1317592 - don't try syncing other engines after one fails with a shutdown error.

https://reviewboard.mozilla.org/r/93022/#review93150

::: services/sync/modules/stages/enginesync.js:334
(Diff revision 1)
>          // appropriate value.
>          return false;
>        }
> +      // Note that policies.js has already logged info about the exception...
> +      if (Async.isShutdownException(e)) {
> +        // Failure due to a shutdown exception should prevent other engines

Log here?
Attachment #8810718 - Flags: review?(rnewman) → review+
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/13a9d632e987
don't try syncing other engines after one fails with a shutdown error. r=rnewman
https://hg.mozilla.org/mozilla-central/rev/13a9d632e987
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.