Mercurial.vcs_checkout() should use HG_SHARED_DIR when vcs_share_base is not defined

RESOLVED FIXED

Status

Release Engineering
General Automation
--
critical
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rail, Assigned: rail)

Tracking

unspecified

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
https://tools.taskcluster.net/task-inspector/#er2SVtaXSGKHKir-85KxQg/0 failed to clone the tools repo which is defined in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/release/generate-checksums.py#230 because it doesn't pass the check defined in https://dxr.mozilla.org/mozilla-beta/source/testing/mozharness/mozharness/base/vcs/mercurial.py#362

19:36:56    FATAL - Automation Error: Can't checkout /tools/checkouts/build-tools!
19:36:56    FATAL - Caught exception: vcs share base not defined; refusing to operate sub-optimally

When Mercurial.vcs_checkout() is called, sometimes it may set vcs_share_base to None in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#70-71.

Later when https://dxr.mozilla.org/mozilla-beta/source/testing/mozharness/mozharness/base/vcs/mercurial.py#356 is executed, it finds that value set to None and doesn't use HG_SHARED_DIR.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Duplicate of this bug: 1317582
(Assignee)

Comment 3

a year ago
This is blocking 51.0b1
Severity: normal → critical

Comment 4

a year ago
mozreview-review
Comment on attachment 8810719 [details]
Bug 1317593 - Fix logic in settings vcs_share_base

https://reviewboard.mozilla.org/r/93026/#review93204
Attachment #8810719 - Flags: review?(gps) → review+

Comment 5

a year ago
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c8359a83645
Fix logic in settings vcs_share_base r=gps
(Assignee)

Comment 6

a year ago
pushed to beta to unblock b1: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=f4f4fce526f54e4d4339fc6e5d87320df6126da6

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0c8359a83645
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 8

a year ago
I also pushed this to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/04cf8fc99ad61779d537ece9c935d2f1bcebbbce
You need to log in before you can comment on or make changes to this bug.