1317593 - Mercurial.vcs_checkout() should use HG_SHARED_DIR when vcs_share_base is not defined

Status: RESOLVED FIXED

Description

[Rail Aliiev [:rail]]

https://tools.taskcluster.net/task-inspector/#er2SVtaXSGKHKir-85KxQg/0 failed to clone the tools repo which is defined in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/release/generate-checksums.py#230 because it doesn't pass the check defined in https://dxr.mozilla.org/mozilla-beta/source/testing/mozharness/mozharness/base/vcs/mercurial.py#362

19:36:56    FATAL - Automation Error: Can't checkout /tools/checkouts/build-tools!
19:36:56    FATAL - Caught exception: vcs share base not defined; refusing to operate sub-optimally

When Mercurial.vcs_checkout() is called, sometimes it may set vcs_share_base to None in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#70-71.

Later when https://dxr.mozilla.org/mozilla-beta/source/testing/mozharness/mozharness/base/vcs/mercurial.py#356 is executed, it finds that value set to None and doesn't use HG_SHARED_DIR.

Comment 1

[Rail Aliiev [:rail]]

Attachment: Bug 1317593 - Fix logic in settings vcs_share_base

Review commit: https://reviewboard.mozilla.org/r/93026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93026/

Comment 3

[Rail Aliiev [:rail]]

This is blocking 51.0b1

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8810719 [details]
Bug 1317593 - Fix logic in settings vcs_share_base

https://reviewboard.mozilla.org/r/93026/#review93204

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c8359a83645
Fix logic in settings vcs_share_base r=gps

Comment 6

[Rail Aliiev [:rail]]

pushed to beta to unblock b1: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=f4f4fce526f54e4d4339fc6e5d87320df6126da6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c8359a83645

Comment 8

[Rail Aliiev [:rail]]

I also pushed this to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/04cf8fc99ad61779d537ece9c935d2f1bcebbbce