1317606 - Get rid of LegacyIsCallerChromeOrNativeCode in barprop code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Can use NeedsCallerType instead.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get rid of LegacyIsCallerChromeOrNativeCode in barprop code

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8810735 [details] [diff] [review]
Get rid of LegacyIsCallerChromeOrNativeCode in barprop code

Review of attachment 8810735 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/BarProps.cpp
@@ +115,5 @@
>  {
>  }
>  
>  bool
> +MenubarProp::GetVisible(CallerType aCallerType, ErrorResult& aRv)

Why are we adding aCallerType to all these methods but not using it or passing it anywhere?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Why are we adding aCallerType to all these methods but not using it or passing it anywhere?

We have 5 implementations of BarProp.  Only one of them actually cares about the argument, but they're all implementing the same virtual function, so we need to add it to all 5 implementations.

The one that cares about the argument cares about it in the setter, not the getter.  But NeedsCallerType doesn't have a way to specify that it's for a setter only or a getter only when used on an attribute.  I could add that to codegen, but it hasn't seemed worth the complexity...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55ceefe2f5aa
Get rid of LegacyIsCallerChromeOrNativeCode in barprop code.  r=bkelly

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55ceefe2f5aa