Closed Bug 1317625 Opened 3 years ago Closed 3 years ago

Stop using xpc::AccesCheck in webgl code

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

It's not really public API so much.
Note that this enables the debugging extensions in chrome workers.  Please let me know if that shouldn't be done for some reason.
Attachment #8810737 - Flags: review?(jgilbert)
Attachment #8810737 - Flags: review?(jgilbert) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9f88713123d
Stop using xpc::AccessCheck in WebGL code.  r=jgilbert
https://hg.mozilla.org/mozilla-central/rev/f9f88713123d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Let's take this to minimize webgl2 discrepancies between 53 and 51.
Let's actually wontfix for 51/52. Ideally we don't need to uplift this, and this shouldn't cause merge conflicts.
It's causing merge conflicts with bug 1324543. Let's take it.
Comment on attachment 8810737 [details] [diff] [review]
Stop using xpc::AccessCheck in WebGL code

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8810737 - Flags: approval-mozilla-beta?
Attachment #8810737 - Flags: approval-mozilla-aurora?
Comment on attachment 8810737 [details] [diff] [review]
Stop using xpc::AccessCheck in WebGL code

Fix WebGL2 related issue. Beta51+ & Aurora52+. Should be in 51 beta 10.
Attachment #8810737 - Flags: approval-mozilla-beta?
Attachment #8810737 - Flags: approval-mozilla-beta+
Attachment #8810737 - Flags: approval-mozilla-aurora?
Attachment #8810737 - Flags: approval-mozilla-aurora+
Merge conflict, the conflict files:
? devtools/client/webconsole/new-console-output/components/grip-message-body.js.rej
? dom/canvas/WebGLContext.h.orig
? dom/media/webrtc/MediaTrackConstraints.cpp.rej
? dom/media/webrtc/MediaTrackConstraints.h.rej
? dom/media/webvtt/vtt.jsm.rej
? dom/tests/mochitest/pointerlock/mochitest.ini.rej
? dom/tests/mochitest/pointerlock/test_pointerlock-autoclose.html.rej
? dom/workers/WorkerRunnable.cpp.rej
? gfx/angle/src/commit.h.orig
? gfx/gl/GLReadTexImageHelper.cpp.rej
? gfx/thebes/DeviceManagerD3D11.h.rej
? js/src/vm/Debugger.cpp.rej
? testing/web-platform/meta/webvtt/webvtt-file-format-parsing/webvtt-file-parsing/001.html.ini.rej
? toolkit/xre/glxtest.cpp.rej
? widget/GfxDriverInfo.cpp.rej
? widget/GfxDriverInfo.h.rej
? widget/GfxInfoBase.cpp.rej
? widget/GfxInfoBase.h.rej
? widget/GfxInfoX11.cpp.rej
? widget/GfxInfoX11.h.rej
bz: can you look at the conflicts ?
Flags: needinfo?(bzbarsky)
Of that list of files, the only one this patch even touched was dom/canvas/WebGLContext.h, right?
Flags: needinfo?(bzbarsky)
Blocks: 1324543
https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=392343acec551a02d4ca15acf22f1578e6fdca70

WebIDL.WebIDLError: error: Unknown extended attribute NeedsCallerType on method, c:/builds/moz2_slave/m-beta-w32-0000000000000000000/build/src/dom/webidl/WebGLRenderingContext.webidl line 541:13

Can we just not take this patch in 51?
I can rebase the dependent patches, if so.
Flags: needinfo?(bzbarsky)
NeedsCallerType was added in 1316619, so look like not on 51.

> Can we just not take this patch in 51?

Absolutely.

I offered to rebase bug 1324543 without it and no one took me up on it...
Flags: needinfo?(bzbarsky)
Working on backing this out from beta and fixing bug 1324543 to build without it.
You need to log in before you can comment on or make changes to this bug.