1317625 - Stop using xpc::AccesCheck in webgl code

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's not really public API so much.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using xpc::AccessCheck in WebGL code

Note that this enables the debugging extensions in chrome workers.  Please let me know if that shouldn't be done for some reason.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9f88713123d
Stop using xpc::AccessCheck in WebGL code.  r=jgilbert

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f9f88713123d

Comment 4

[Kelsey Gilbert [:jgilbert]]

Let's take this to minimize webgl2 discrepancies between 53 and 51.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Let's actually wontfix for 51/52. Ideally we don't need to uplift this, and this shouldn't cause merge conflicts.

Comment 6

[Kelsey Gilbert [:jgilbert]]

It's causing merge conflicts with bug 1324543. Let's take it.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8810737 [details] [diff] [review]
Stop using xpc::AccessCheck in WebGL code

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8810737 [details] [diff] [review]
Stop using xpc::AccessCheck in WebGL code

Fix WebGL2 related issue. Beta51+ & Aurora52+. Should be in 51 beta 10.

Comment 9

[Iris Hsiao [:ihsiao]]

Merge conflict, the conflict files:
? devtools/client/webconsole/new-console-output/components/grip-message-body.js.rej
? dom/canvas/WebGLContext.h.orig
? dom/media/webrtc/MediaTrackConstraints.cpp.rej
? dom/media/webrtc/MediaTrackConstraints.h.rej
? dom/media/webvtt/vtt.jsm.rej
? dom/tests/mochitest/pointerlock/mochitest.ini.rej
? dom/tests/mochitest/pointerlock/test_pointerlock-autoclose.html.rej
? dom/workers/WorkerRunnable.cpp.rej
? gfx/angle/src/commit.h.orig
? gfx/gl/GLReadTexImageHelper.cpp.rej
? gfx/thebes/DeviceManagerD3D11.h.rej
? js/src/vm/Debugger.cpp.rej
? testing/web-platform/meta/webvtt/webvtt-file-format-parsing/webvtt-file-parsing/001.html.ini.rej
? toolkit/xre/glxtest.cpp.rej
? widget/GfxDriverInfo.cpp.rej
? widget/GfxDriverInfo.h.rej
? widget/GfxInfoBase.cpp.rej
? widget/GfxInfoBase.h.rej
? widget/GfxInfoX11.cpp.rej
? widget/GfxInfoX11.h.rej

Comment 10

[Carsten Book [:Tomcat]]

bz: can you look at the conflicts ?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch that applies to Aurora

Of that list of files, the only one this patch even touched was dom/canvas/WebGLContext.h, right?

Comment 12

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72990bca82a9

Comment 13

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c56fe501d3ea

Comment 14

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=392343acec551a02d4ca15acf22f1578e6fdca70

WebIDL.WebIDLError: error: Unknown extended attribute NeedsCallerType on method, c:/builds/moz2_slave/m-beta-w32-0000000000000000000/build/src/dom/webidl/WebGLRenderingContext.webidl line 541:13

Can we just not take this patch in 51?
I can rebase the dependent patches, if so.

Comment 15

[Boris Zbarsky [:bzbarsky]]

NeedsCallerType was added in 1316619, so look like not on 51.

> Can we just not take this patch in 51?

Absolutely.

I offered to rebase bug 1324543 without it and no one took me up on it...

Comment 16

[Boris Zbarsky [:bzbarsky]]

Working on backing this out from beta and fixing bug 1324543 to build without it.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Done:

 https://hg.mozilla.org/releases/mozilla-beta/rev/eb1f0e25f42fdeaf279f994c5644e94e9885947b
 https://hg.mozilla.org/releases/mozilla-beta/rev/f5deff76fdfccdf38fd9b631f597210d85c8b3e5