1317631 - Crash in android.database.CursorIndexOutOfBoundsException: Index -1 requested, with a size of 10 at android.database.AbstractCursor.checkPosition(AbstractCursor.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Andrzej Hunt :ahunt]

This bug was filed from the Socorro interface and is 
report bp-336a7a1a-35d6-4911-a5a9-bc0112161114.
=============================================================

STR:
1. Enable Activity Stream
2. Tap the "highlights" title

Comment 1

[Andrzej Hunt :ahunt]

Introduced in Bug 1312434

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1317631 - Only handle clicks for highlights

This avoids us trying to obtain an invalid cursor position, since
the cursor only maps to highlights items (and not the headers).

Review commit: https://reviewboard.mozilla.org/r/93314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93314/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1317631 - Post: add more cursor position sanity checks

Review commit: https://reviewboard.mozilla.org/r/93316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93316/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811098 [details]
Bug 1317631 - Only handle clicks for highlights

https://reviewboard.mozilla.org/r/93314/#review93350

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811099 [details]
Bug 1317631 - Post: add more cursor position sanity checks

https://reviewboard.mozilla.org/r/93316/#review93352

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f5da9786e9
Only handle clicks for highlights r=sebastian
https://hg.mozilla.org/integration/autoland/rev/399dea6e9200
Post: add more cursor position sanity checks r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6f5da9786e9
https://hg.mozilla.org/mozilla-central/rev/399dea6e9200

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Looks like this should get uplifted to 52 as well? Please request Aurora approval on the patches when you get a chance.

Comment 9

[Andrzej Hunt :ahunt]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> Looks like this should get uplifted to 52 as well? Please request Aurora
> approval on the patches when you get a chance.

This is for an incomplete and currently still disabled feature that definitely won't be shipped or enabled in 52. I.e. in this case there's no need to uplift it because no user will ever run this code (there's no harm in uplifting either - just more effort). (This is part Activity Stream on Android, which will probably ride the trains in a future release - we're still actively developing and testing on nightly. In 52 that code is protected by a build flag.)

I wonder if there's some way to tag crashes that wouldn't need uplifting, would changing the Version field be enough to not make it seem like uplift is needed?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Status flags are the answer you're looking for, thanks for the info!