Closed Bug 1317643 Opened 4 years ago Closed 4 years ago

Account Avatar Icon in Sync settings page reset to default when debug mode toggled

Categories

(Firefox for Android :: Firefox Accounts, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- verified

People

(Reporter: maliu, Assigned: seanmaltby, Mentored)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

STR:
 * Enter Account sync settings, toggle to enable debug mode.

Expected Behaviour:
 * Account avatar icon stay still, not to be reset to default.
i want to try this
(In reply to Ajinkya from comment #1)
> i want to try this

Sure! Have you setup a build environment yet?
Flags: needinfo?(ajinkyaambre9394)
Hi Max, 
I tried to reproduce the issue with following steps, 

1. created firefox android (version 50.0.1) sync account on my device
2. set the account picture
3. then enabled debug mode via firefox settings -> advanced -> Developer Tools -> Remote Debugging via USB, then toggled it.
4. went back to sync settings page

as per the issue, now account picture should have been reset to default avatar, but that didn't happened and I can see the originally set account picture been displayed as usual.


I believe the above steps are right, if not then please correct it else what am I missing or issue might be not reproducible?
Flags: needinfo?(max)
Hi Ankur,

Sorry maybe bug description not clear enough. The debug mode be inside the account syncing debug purpose. So it only exist in Nightly version. Your step 3 should be replaced to "Settings -> account -> menu -> toggle debug mode"
Flags: needinfo?(max)
(In reply to Max Liu [:maliu] from comment #2)
> (In reply to Ajinkya from comment #1)
> > i want to try this
> 
> Sure! Have you setup a build environment yet?

yes i did.
The bug is still active but know the procedure to replicate it is:
Settings->Acount(E-mail/Username)->More->enable Debug-mode
Can you point me out somewhere where i can see documentation about the contents of the mozilla-center/mobile folder? just to find out where should i start looking for the source of this bug
Flags: needinfo?(s.kaspari)
Mentor: s.kaspari
Flags: needinfo?(s.kaspari) → needinfo?(max)
Hi Francisco,

Since it's a Android Preference, you can start from [1] PreferenceFragment. After that, you may find out that account page is implemented by [2] FxAccountStatusFragment. Checkout which member field stores the data row with icon and account name?

[1] https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/mobile/android/services/src/main/java/org/mozilla/gecko/background/preferences/PreferenceFragment.java

[2] https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusFragment.java
Flags: needinfo?(max)
Not sure if I submitted that correctly, but I believe I fixed the issue in the above commit.
Comment on attachment 8829178 [details]
Bug 1317643 - Resolved issue where the avatar icon resets to default.

https://reviewboard.mozilla.org/r/106340/#review107728

LGTM
Attachment #8829178 - Flags: review?(max) → review+
Flags: needinfo?(ajinkyaambre9394)
Assignee: nobody → seanmaltby
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a29f11fae377
Resolved issue where the avatar icon resets to default. r=maliu
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a29f11fae377
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Hello I've verified this issue using a Samsung Galaxy Note 4 (Android 5.0.1), seems to be working fine as the account picture is not reset.
You need to log in before you can comment on or make changes to this bug.