Closed
Bug 1317705
Opened 8 years ago
Closed 8 years ago
SessionStore.duplicateTab discards its 4th argument and always uses default.
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
The method SessionStore.duplicateTab does not pass its aRestoreImmediately argument through the public shim to SessionStoreInternal.duplicateTab.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: ENRssR9Wmun
Attachment #8810864 -
Flags: review?(dteller)
Comment on attachment 8810864 [details] [diff] [review] Pass aRestoreImmediately through to SessionStoreInternal Review of attachment 8810864 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks.
Attachment #8810864 -
Flags: review?(dteller) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/100920157ed0 Pass aRestoreImmediately through to SessionStoreInternal, r=Yoric
I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39225184&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/21c34e0253358ec53a5e689f83dfcf70b3ad4964
Flags: needinfo?(michael)
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0cc3a3f1c16a Pass aRestoreImmediately through to SessionStoreInternal, r=Yoric a=kwierso CLOSED TREE
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(michael)
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0cc3a3f1c16a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•