1317819 - Webconsole logging no longer works after opening the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Julian Descottes [:jdescottes]]

Regression from the last debugger update (Bug 1316413). 

STRs:
- open devtools
- go to debugger (with new debugger frontend)
- go to console (either old or new frontend)
- send "console.log(1)"

ER: should log 1 in the console
AR: input is not cleared, 1 is not logged etc ...

In the Browser console we can see "TypeError frames is null" errors from debugger/new/panel.js (:53)

Looks like the breaking change was introduced by the following PR:
https://github.com/devtools-html/debugger.html/pull/1094

I suppose we should update the check done in panel.js from `!frames.toJS` to `!frames || !frames.toJS`, which is why I am logging this one in Bugzilla rather than on Github.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1317819 - avoid typeerror when getting debugger frames from webconsole;

Review commit: https://reviewboard.mozilla.org/r/93286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93286/

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1317819 - eslint cleanup of /debugger/new/panel.js;

Review commit: https://reviewboard.mozilla.org/r/93288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93288/

Comment 3

[Julian Descottes [:jdescottes]]

If I understand correctly, getFrames() is always returning either a Seq (ie. with toJS() available) or null. Updated the check in panel.js accordingly. Adding a test would be nice though, I'll try to come up with one.

Comment 4

[Jason Laster [:jlast]]

Comment on attachment 8811048 [details]
Bug 1317819 - avoid typeerror when getting debugger frames from webconsole;

Looks good

Comment 5

[Jason Laster [:jlast]]

Comment on attachment 8811049 [details]
Bug 1317819 - eslint cleanup of /debugger/new/panel.js;

Thanks

Comment 6

[Jason Laster [:jlast]]

I'd be happy to add a test later when I work on this bug: 
https://github.com/devtools-html/debugger.html/issues/717

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the reviews!

Comment 8

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b105a45f13c47115078aeb5d6bb3497fcdcbe5aa

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8811049 [details]
Bug 1317819 - eslint cleanup of /debugger/new/panel.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93288/diff/1-2/

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8811049 [details]
Bug 1317819 - eslint cleanup of /debugger/new/panel.js;

updated the commit message, not sure why the r+ was not forwarded to the new patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f1a12e87f4b
avoid typeerror when getting debugger frames from webconsole;r=jlast
https://hg.mozilla.org/integration/mozilla-inbound/rev/8df90c97d9e8
eslint cleanup of /debugger/new/panel.js;r=jlast

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f1a12e87f4b
https://hg.mozilla.org/mozilla-central/rev/8df90c97d9e8

Comment 14

[areya]

https://hg.mozilla.org/mozilla-central/rev/0f1a12e87f4b
https://hg.mozilla.org/mozilla-central/rev/8df90c97d9e8

Comment 15

[Julian Descottes [:jdescottes]]

Comment on attachment 8811048 [details]
Bug 1317819 - avoid typeerror when getting debugger frames from webconsole;

This has been on mc for a few days, I think we should uplift now.

Approval Request Comment
[Feature/regressing bug #]:1316413
[User impact if declined]: webconsole can not be used after opening the debugger
[Describe test coverage new/current, TreeHerder]: no tests at the moment (being added in https://github.com/devtools-html/debugger.html/pull/1238)
[Risks and why]: simple JavaScript one liner 
[String/UUID change made/needed]: N/A

Comment 16

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly according to (2016-11-15)

Fixing bug is verified on latest Nightly-- Build ID:(20161121030224), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0


Testes OS-- Windows10 32bit

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 8811048 [details]
Bug 1317819 - avoid typeerror when getting debugger frames from webconsole;

fix debugger regression in aurora52

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/36be34c8798a
https://hg.mozilla.org/releases/mozilla-aurora/rev/a9646c7ac30f

Comment 19

[Azmina]

I have reproduced this bug with Nightly 53.0a1 (2016-11-15) (32-bit) on Windows 8.1 (64-bit).

This bug's fix is verified on Aurora 52.0a2 (2017-01-03) (32-bit).

Build ID : 20170103004005
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20170104]