1317872 - Screen sharing track does not end when the window is closed

Status: NEW

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Wang Guan]

Attachment: gum-screenshare.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161104212021

Steps to reproduce:

1. Open the attached page from a https domain.

2. Select a window to share (the screen-sharing stream is then displayed in browser)

If you see a 'NotAllowedError' instead of a prompt pop-up, please add the domain (e.g. *.bmoattachments.org ) to `media.getusermedia.screensharing.allowed_domains` in about:config 

3. Close the shared window


Actual results:

MediaStreamTrack of the shared window freezes, and a 'ended' event is not fired.

(In case it fires, you will see `'ended' event fired at videoTrack1` text in page)


Expected results:

I expected a 'ended' event to be fired (as in chrome)

note. the page I attached is not meant to work in chrome, which requires an extension to call some private API.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

I'm pretty sure we've never fired 'ended' for window or app (or screens) which go away during sharing.  No idea if the spec speaks to it, though it might.

Comment 2

[Andreas Pehrson [:pehrsons]]

(In reply to Randell Jesup [:jesup] from comment #1)
> I'm pretty sure we've never fired 'ended' for window or app (or screens)
> which go away during sharing.

We haven't, since the feature is new. It seems like the right thing to do though.

Comment 3

[Wang Guan]

Didn't know the event wasn't implemented o_o

Comment 4

[Andreas Pehrson [:pehrsons]]

The event as such is implemented, but it came in 50 so it's new in release since this week.

The workaround for users is to end the window share through browser chrome (the little button on the left of the address bar), which I imagine is a more common use case.

Comment 5

[Paul Adenot (:padenot)]

Can this be closed now? Do we have tests for this?

Comment 6

[Wang Guan]

padenot: This still happens in firefox 55 / osx.

Comment 7

[Andreas Pehrson [:pehrsons]]

The event is there but we don't signal it when a shared window is closed yet.

Comment 8

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 11

[btham]

Hi, I'm the original filer for https://bugzilla.mozilla.org/show_bug.cgi?id=1741471. I was wondering if there's any progress on this, since it's still affecting our browser client for Webex.