Closed Bug 1317947 Opened 4 years ago Closed 4 years ago

Upgrade Firefox 53 to NSS 3.29

Categories

(Core :: Security: PSM, defect, P1)

53 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 + fixed

People

(Reporter: franziskus, Assigned: franziskus)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file, 1 obsolete file)

Tracking NSS 3.29 for Firefox 53.
Target Milestone: --- → mozilla53
forgot to set leave-open. there will be more landings
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Priority: -- → P1
Whiteboard: [psm-assigned]
Depends on: 1311619
Attached image mozilla-test-fail-screenshot_8OwCIR.png (obsolete) —
backed out for causing timeouts in dt tests like https://treeherder.mozilla.org/logviewer.html#?job_id=70274867&repo=mozilla-inbound

however the real issue might be the error message in the attachment, this might be explain why a nss change breaks devtools tests
Flags: needinfo?(franziskuskiefer)
[task 2017-01-19T08:54:09.131407Z] 08:54:09     INFO -  "handling good.include-subdomains.pinning.example.com"
[task 2017-01-19T08:54:09.131705Z] 08:54:09  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_cert_chains.js |  - Actual and expected connection result should match - 2153394174 == 0
[task 2017-01-19T08:54:09.131988Z] 08:54:09     INFO -  /storage/sdcard/tests/xpc/security/manager/ssl/tests/unit/head_psm.js:add_connection_test/</<:454

2153394174 is SSL_ERROR_NO_CYPHER_OVERLAP - could it be that the cipher suites that are enabled by default in NSS no longer overlap with what Firefox enables?
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2164277367cc
land NSS ea43fcc316e1, r=me
https://hg.mozilla.org/integration/autoland/rev/3112cbcca0f4
Backed out changeset 2164277367cc for causing timeouts in devtools tests on a CLOSED TREE
Depends on: 1323104
Flags: needinfo?(franziskuskiefer)
Depends on: 1333247
Attachment #8828251 - Attachment is obsolete: true
No longer depends on: 1333247
Depends on: 1334114
Depends on: 1334474
Attached patch 329ff53.patchSplinter Review
Final NSS 3.29 release for Firefox 53 that currently holds the latest 3.29 beta.
Flags: needinfo?(lhenry)
Attachment #8833910 - Flags: review+
Attachment #8833910 - Flags: approval-mozilla-aurora?
Comment on attachment 8833910 [details] [diff] [review]
329ff53.patch

Let's get the final/release version of NSS 3.29 to replace the beta version, onto aurora.
Flags: needinfo?(lhenry)
Attachment #8833910 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tweaking the flag so this will show in queries. 
Franziskus, do you want to land this on aurora yourself or would you like someone else to do it?
Flags: needinfo?(franziskuskiefer)
https://hg.mozilla.org/releases/mozilla-aurora/rev/9ad41a8fca06
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Flags: needinfo?(franziskuskiefer)
Keywords: leave-open
Resolution: --- → FIXED
Depends on: 1385790
You need to log in before you can comment on or make changes to this bug.