1318019 - Grid highlighter disappears after editing a property and focusing another one

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

STR:

- Open http://labs.jensimmons.com/examples/grid-content-1.html
- open the inspector
- find and select the <main> element
- in the rule-view, click on the grid icon next to display:grid;
- click on the "repeat(5, 16vw)" value
- change this value to something else, like "repeat(5, 17vw)"
- click on another value, like the one just below it "repeat(12, 16vw)"

=> The grid highlighter is hidden. It should remain visible.

This is most probably because the whole rule is refreshed and we loose some piece of state in the meantime.

This is related to bug 1302536. Not sure if it should block it, but it seriously impacts the usefulness of this feature.

Comment 1

[Patrick Brosset <:pbro>]

In fact, in the last step of the STR in the previous comment, you do not need to click inside another value. Just blurring the first value will do it.

Gabriel: can you think of a way to fix this?

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1318019.patch

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1318019.patch [1.0]

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1318019.patch [2.0]

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef23bf8110953349a23ba2e344c20643b392eda0
Bug 1318019 - Add missing () to call isDisplayGrid function when a property value editor closes. r=me

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8811575 [details] [diff] [review]
1318019.patch [2.0]

Approval Request Comment
[Feature/regressing bug #]: 1302536
[User impact if declined]: Grid highlighter disappears after editing any property values in the rule-view.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: This is a trivial fix for a function that should've been called.
[String/UUID change made/needed]: None.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef23bf811095

Comment 8

[Nawaf Chowdhury Akash]

I've Successfully reproduce this bug in Nightly 53.0a1 (2016-11-16) on windows 10 ,32 bit.


This Bug is now verified as fixed on Latest Nightly 53.0a1 (2016-11-19).

Build ID : 20161119030204.
User Agent : Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8811575 [details] [diff] [review]
1318019.patch [2.0]

followup fix for bug 1302536, should land in aurora52 together

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d7e295bdc1f