1318048 - Network request information hidden when window width too narrow

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[u424271]

Steps to reproduce:
1) Open developer tools and go to network tab
2) Do something to cause requests over the network
3) Decrease the window width
4) At some point the network activity will disappear

The smallest window size where I still see the network activity is:
window.innerWidth = 701 (window.outerWidth = 713)

Happens in:
53.0a1 (2016-11-16) (64-bit)
51.0b1 (32-bit and 64-bit)
50.0 (64-bit)

Didn't happen in:
49.0.2 (64-bit)

Comment 1

[Loic]

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fcfd05
dd7d14472c6f5df5ecdb58019b2fce93f3&tochange=a5ee1d48d2f559ae0775463ae6cc7fee8119
c3b1

Yura Zenevich — Bug 1226877 - make collapsed details pane hidden using visibility: hidden to be inaccessible by both keyboard and a11y tools. r=bgrins

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report. I can clearly reproduce the problem.

This bug is related to vertical-layout mode that DevTools Toolbox is automatically switching into when the browser window width is small. Note that there is a splitter displayed at the top of the net panel content after you make the browser window small and the content disappears. You can drag the splitter down to see the content again. Looks like the min height is not set.

Note that the network panel is currently being refactored. We are removing XUL and using React/HTML to generate the UI. I think this bug is blocked by it. I believe that by bug 1309183.


Honza

Comment 3

[Gerry Chang [:gchang]]

Track 51+/52+/53+ as regression in network monitor of devtools.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1318048 patch

I realize this is being reworked without xul, just fixing the issue with the current implementation. I should've not removed the responsive style, they are not mutually exclusive.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8814218 [details] [diff] [review]
1318048 patch

Review of attachment 8814218 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.  Please update the commit message to explain what this is fixing

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2411fdf8a816
fixing regression where network requests list is cut off for screens narrower than 700px. r=bgrins

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2411fdf8a816

Comment 9

[Gerry Chang [:gchang]]

Hi :yzen,
Can you help nominate this for Aurora/Beta approval if it's not too risky?

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8814218 [details] [diff] [review]
1318048 patch

This patch fixes regression introduced when worked on a11y visibility of dev tools panels. The style that was removed for small screens was not mutually exclusive with the a11y fixes and should've not been removed.
[Feature/Bug causing the regression]: bug 1226877
[User impact if declined]: Network monitor looks broken when devtools container has width less than 700px
[Is this code covered by automated tests?]: No, a 1 line CSS change
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: Yes:
* Open firefox
* Open devtools network monitor
* Visit some website to get network activity
* Resize browser window to smaller than 700px width.
* Before the fix: network history gets cut off or disappears
* After the fix: network history looks normal and not cut off
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: likely not
[Why is the change risky/not risky?]: a small CSS change that only affects network panel when the width is small
[String changes made/needed]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8814218 [details] [diff] [review]
1318048 patch

css-only change to fix a devtools annoyance, seems like an easy 50.1 ride-along

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8814218 [details] [diff] [review]
1318048 patch

Recent regression in 50, approved for all branches.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d56db78b13c3

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f600b6da32d7

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/6495b0cddf13

Comment 16

[Ricardo]

Someone should add a horizontal scrollbar to the Network panel also.

Comment 17

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Ricardo from comment #16)
> Someone should add a horizontal scrollbar to the Network panel also.
Please file a new bug so, it isn't forgotten (since this report is already closed).
Honza

Comment 18

[Ciprian Georgiu, Desktop QA]

I've managed to reproduce this issue with an Nightly build from 2016-11-06, following the Str from comment 0.

This is verified fixed on latest Nightly 53.0a1 (2016-12-19), latest Aurora 52.0a2 (2016-12-19), 51 beta 8 (20161215085501) and 50.1.0 (20161208153507) across OSes:
- Windows 10 x64
- Ubuntu 16.04 x64 LTS
- Mac OS X 10.11.6