Closed Bug 1318066 Opened 3 years ago Closed 3 years ago

Package up the webrender shaders so that they are in the installer

Categories

(Core :: Graphics: WebRender, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox53 --- affected

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Right now the webrender binding code just reads the WR shaders from the res/ subfolder under the cargo manifest path, but this is evaluated at compile-time. If the build is compiled on one machine and moved to another machine then it fails on startup because it can't find the path.

https://github.com/servo/webrender/issues/352 covers a webrender change to compile in the shaders but until that is done we can work around it by packaging the shaders as part of the firefox packaging process. This can be backed out later once we get a webrender update that includes compiled-in shaders.
That was quicker than I anticipated: vlad landed a patch in webrender to compile in the shaders in https://github.com/servo/webrender/pull/563

When we update our copy of webrender to a version that includes that, we can back out these patches.
ni myself so I don't forget to do this backout after the update.
Depends on: 1318440
Flags: needinfo?(bugmail)
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/d17759dd3b74
Revert the changes for packing the webrender shaders. r=kats?
Thanks!
Flags: needinfo?(bugmail)
Resolution: FIXED → WORKSFORME
Depends on: 1318613
No longer depends on: 1318440
You need to log in before you can comment on or make changes to this bug.