1318066 - Package up the webrender shaders so that they are in the installer

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now the webrender binding code just reads the WR shaders from the res/ subfolder under the cargo manifest path, but this is evaluated at compile-time. If the build is compiled on one machine and moved to another machine then it fails on startup because it can't find the path.

https://github.com/servo/webrender/issues/352 covers a webrender change to compile in the shaders but until that is done we can work around it by packaging the shaders as part of the firefox packaging process. This can be backed out later once we get a webrender update that includes compiled-in shaders.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/projects/graphics/rev/fdfd418626ad2bedc33a6bd813a3472617a9b1e3
https://hg.mozilla.org/projects/graphics/rev/6aeb295d19b80c368cb3a31a096ac76b745797df

Comment 2

[Kartikaya Gupta (email:[e-mail])]

That was quicker than I anticipated: vlad landed a patch in webrender to compile in the shaders in https://github.com/servo/webrender/pull/563

When we update our copy of webrender to a version that includes that, we can back out these patches.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

ni myself so I don't forget to do this backout after the update.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/d17759dd3b74
Revert the changes for packing the webrender shaders. r=kats?

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Kats,
Bug 1318613 includes the PR: https://github.com/servo/webrender/pull/563 .
So, comment 4 do the reversion.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Thanks!