Closed
Bug 1318086
Opened 8 years ago
Closed 8 years ago
Move sanitizeArgs into DOMLocalization
Categories
(L20n :: JS Library, defect)
L20n
JS Library
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
Now that bug 1316083 has landed we should move the sanitizeArgs logic to DOMLocalization. it sanitizes HTML tags and entities. It will also help with bug 1288443.
|
Assignee | |
Comment 1•8 years ago
|
||
Zibi, in this PR I've moved sanitizeArgs to be a method of DOMLocalization, and entityFromContext and valueFromContext to be methods of Localization. This should help in scenarios where we'd benefit from overriding entityFromContext in a subclass, e.g. in DOMLocalization to implement a special fallback for XUL labels (bug 1288443).
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8811441 [details] [review] Pull request r+
Attachment #8811441 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Landed in l20n.js: https://github.com/l20n/l20n.js/commit/1ad935c5a00c6529411c76d5b1544ed8a2a45c16
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/3b73e706c1b0e4c65e8350fca520e3129ed99a9f Bug 1318086 - Allow subclasses to override sanitizeArgs etc. r=gandalf
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•