1318092 - Re-check user logged-in status in ThModelErrors after HTTP 403 API responses

Status: RESOLVED INVALID

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Cameron Dawson [:camd]]

Extract the block from ``ui/js/components/auth.js`` to a reusable place and use it in ThModelErrors to double-check the user logged in status on errors.

Comment 1

[Ed Morley [:emorley]]

This will help the UX for when people go to retrigger but there's an auth failure, since if they've been signed out in the meantime (eg the server cleared logged in sessions or rotated the secret key) the logged in/out state will be updated to make the reason clearer.

Note this overlaps slightly with:
* Bug 1342904 - Logging out in one tab should log the other tabs out
  -> Though this only helps with the "user chose to sign out themselves" case
* Bug 1340590 - The UI always blames API 403s on not being logged in when there can be other causes
  -> Though this only helps with the error message, and doesn't update the logged in/out state (which would save the user an extra step)

Comment 2

[Ed Morley [:emorley]]

STR:
1. Log into Treeherder (post Auth0 switch) and leave the page open
2. Truncate the treeherder.django_session table (or clear the cache, if we end up switching to cache-based in bug 1310241) to force the session to expire
3. Without refreshing the Treeherder page (which at that point still displays as logged in, in the UI), select a job and press retrigger

Expected:
* Error message shown saying "please log into treeherder"
* The UI logged in indicator top right of the page changes from displaying my name, to "login/register"

Actual:
* Error message shown saying "please log into treeherder"
* The UI logged in indicator doesn't change, so still incorrectly shows me as logged in (until I refresh the page)

Comment 3

[Sarah Clements [:sclements]]

Outdated.