Closed Bug 1318137 Opened 3 years ago Closed 3 years ago

Implement SpeechSynthesisEvent.charLength

Categories

(Core :: Web Speech, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla53
Tracking Status
firefox53 --- verified

People

(Reporter: eeejay, Assigned: eeejay)

References

()

Details

Attachments

(1 file)

This is showing up next month as an errata to the synth spec, and I think it is very needed.


Section 5.2 IDL: Add to SpeechSynthesisEvent:

        readonly attribute unsigned long charLength;

Section 5.2.5 SpeechSynthesisEvent Attributes: Add:

charLength attribute

This attribute indicates the length of the text (word or sentence)
that will be spoken corresponding to this event. This attribute is the
length, in characters, starting from this event's charIndex.  The user
agent must return this value if the speech synthesis engine supports
it or the user agent can otherwise determine it, otherwise the user
agent must return undefined.

https://www.w3.org/Bugs/Public/show_bug.cgi?id=30004
Comment on attachment 8812528 [details]
Bug 1318137 - Added charLength to speech synth boundary events.

https://reviewboard.mozilla.org/r/94236/#review94816

total good.  But I think that you need additional review to smaug or dom peer for webidl change.
Attachment #8812528 - Flags: review?(m_kato) → review+
Attachment #8812528 - Flags: review?(bugs)
Comment on attachment 8812528 [details]
Bug 1318137 - Added charLength to speech synth boundary events.

https://reviewboard.mozilla.org/r/94236/#review96152
Attachment #8812528 - Flags: review?(bugs) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87694bac79cd
Added charLength to speech synth boundary events. r=m_kato,smaug
https://hg.mozilla.org/mozilla-central/rev/87694bac79cd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1321862
Eitan, does this fix have automated coverage? Would it benefit from manual testing?
Flags: qe-verify?
Flags: needinfo?(eitan)
(In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #6)
> Eitan, does this fix have automated coverage? Would it benefit from manual
> testing?

It would. Using the narrate feature in Windows and Mac would probably be the best manual test.

Thanks for checking!
Flags: needinfo?(eitan)
(In reply to Eitan Isaacson [:eeejay] from comment #7)
> (In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #6)
> > Eitan, does this fix have automated coverage? Would it benefit from manual
> > testing?
> 
> It would. Using the narrate feature in Windows and Mac would probably be the
> best manual test.
> 
> Thanks for checking!

Thank you for following up, Eitan! Flagging this for manual testing.
Flags: qe-verify? → qe-verify+
I have reproduced this issue using Firefox 50.0a1 (2016.06.06) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 53.0b9 on Win 8.1 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.