1318154 - test remote iframe in background page

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: remotebackgroundframe

In one of our outreach meetings the issue of supporting remote iframes in a background page came up.  I didn't know whether it worked or not, so I added a test.  (It does work.)  The test may be useful to add, here's the patch.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8811516 [details] [diff] [review]
remotebackgroundframe

I should fix eslint first.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: remotebackgroundframe

fixed eslint.

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8811517 [details] [diff] [review]
remotebackgroundframe

Review of attachment 8811517 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/test/mochitest/test_ext_subframes_privileges.html
@@ +198,5 @@
>  
> +add_task(function* test_webext_background_remote_subframe_privileges() {
> +  function backgroundSubframeScript() {
> +    window.addEventListener("message", function onmessage(evt) {
> +      window.removeEventListener("message", onmessage, false);

You can pass a `{once: true}` option to addEventListener and then you don't need to remove it here.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1318154 test remote iframe in background page,

Review commit: https://reviewboard.mozilla.org/r/93794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93794/

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8811883 [details]
Bug 1318154 test remote iframe in background page,

https://reviewboard.mozilla.org/r/93794/#review93944

reviewed in bugzilla

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8811517 [details] [diff] [review]
remotebackgroundframe

obsoleted by reviewboard patch

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8811883 [details]
Bug 1318154 test remote iframe in background page,

https://reviewboard.mozilla.org/r/93794/#review94200

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8811883 [details]
Bug 1318154 test remote iframe in background page,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93794/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ce8a9f7f32f
test remote iframe in background page, r=aswan

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ce8a9f7f32f