Closed Bug 1318154 Opened 3 years ago Closed 3 years ago

test remote iframe in background page

Categories

(WebExtensions :: Untriaged, defect, P2)

49 Branch
defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

(Whiteboard: triaged)

Attachments

(1 file, 2 obsolete files)

Attached patch remotebackgroundframe (obsolete) — Splinter Review
In one of our outreach meetings the issue of supporting remote iframes in a background page came up.  I didn't know whether it worked or not, so I added a test.  (It does work.)  The test may be useful to add, here's the patch.
Attachment #8811516 - Flags: review?(aswan)
Comment on attachment 8811516 [details] [diff] [review]
remotebackgroundframe

I should fix eslint first.
Attachment #8811516 - Flags: review?(aswan)
Attached patch remotebackgroundframe (obsolete) — Splinter Review
fixed eslint.
Assignee: nobody → mixedpuppy
Attachment #8811516 - Attachment is obsolete: true
Attachment #8811517 - Flags: review?(aswan)
Comment on attachment 8811517 [details] [diff] [review]
remotebackgroundframe

Review of attachment 8811517 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/test/mochitest/test_ext_subframes_privileges.html
@@ +198,5 @@
>  
> +add_task(function* test_webext_background_remote_subframe_privileges() {
> +  function backgroundSubframeScript() {
> +    window.addEventListener("message", function onmessage(evt) {
> +      window.removeEventListener("message", onmessage, false);

You can pass a `{once: true}` option to addEventListener and then you don't need to remove it here.
Attachment #8811517 - Flags: review?(aswan) → review+
Comment on attachment 8811883 [details]
Bug 1318154 test remote iframe in background page,

https://reviewboard.mozilla.org/r/93794/#review93944

reviewed in bugzilla
Attachment #8811883 - Flags: review+
Comment on attachment 8811517 [details] [diff] [review]
remotebackgroundframe

obsoleted by reviewboard patch
Attachment #8811517 - Attachment is obsolete: true
Comment on attachment 8811883 [details]
Bug 1318154 test remote iframe in background page,

https://reviewboard.mozilla.org/r/93794/#review94200
Attachment #8811883 - Flags: review?(aswan) → review+
Priority: -- → P2
Whiteboard: triaged
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4ce8a9f7f32f
test remote iframe in background page, r=aswan
https://hg.mozilla.org/mozilla-central/rev/4ce8a9f7f32f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.