1318167 - Add support for ICE end of candidate

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

The current spec allows the end of candidates null candidate to passed into addIceCandidate().
We need to add support for the in nICEr and then expose it via the JS API.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Update: http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate now says addIceCandidate needs to support empty string to mean end of candidate gathering.

We also need to update the onicecandidate side to follow the spec [1] which says to emit such a candidate ahead of the existing null canddidate, as mentioned here [2]:

  "Create an RTCIceCandidate instance newCandidate, with sdpMid and sdpMLineIndex set to the values associated with this RTCIceTransport , with ufrag set to the ufrag of the generation of candidates for which gathering finished, with candidate set to an empty string"

[1] http://w3c.github.io/webrtc-pc/#rtcicetransport
[2] https://github.com/w3c/webrtc-pc/issues/1213#issuecomment-301861839

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Once this is fixed, addIceCandidate should no longer allow null as a candidate argument.

Comment 5

[Byron Campen [:bwc]]

There's a spec bug that needs to be worked out here:

https://github.com/w3c/webrtc-pc/issues/2125

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1318167 - Part 0: Re-enable some test-cases.

Comment 7

[Byron Campen [:bwc]]

Attachment: Bug 1318167 - Part 4: Incorporate remote end-of-candidates into SDP.

Depends on D23219

Comment 8

[Byron Campen [:bwc]]

Made a PR here: https://github.com/w3c/webrtc-pc/pull/2127

Going to have to jump through some hoops before it can be merged.

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b01315bb432ea1c9c9afa32f0f1ae9eee3a6ff

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1318167 - Part 2: Several test fixes that webidl changes highlighted, plus suppressions for tests that were succeeding for the wrong reasons.

Depends on D23219

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1318167 - Part 3: Add some testing for a=end-of-candidates in remote SDP.

Depends on D23590

Comment 12

[Byron Campen [:bwc]]

Attachment: Bug 1318167 - Part 1: Give RTCIceCandidateInit.candidate a default value.

Comment 13

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0b06d9947b99cc828303bd5b3270c26485d45d3

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a06608b89846ef6e1f94517b4539310636c72a4f

Comment 15

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=961f4bc2fe79ff480cacd8b69dd2efdbc5bfdb01

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71abf7c1375
Part 0: Re-enable some test-cases. r=jib
https://hg.mozilla.org/integration/autoland/rev/de9898be5bbe
Part 1: Give RTCIceCandidateInit.candidate a default value. r=smaug,jib
https://hg.mozilla.org/integration/autoland/rev/6d0193a41ab4
Part 2: Several test fixes that webidl changes highlighted, plus suppressions for tests that were succeeding for the wrong reasons. r=jib
https://hg.mozilla.org/integration/autoland/rev/b425ca25edc5
Part 3: Add some testing for a=end-of-candidates in remote SDP. r=jib
https://hg.mozilla.org/integration/autoland/rev/151f1392f619
Part 4: Incorporate remote end-of-candidates into SDP. r=mjf

Comment 17

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e71abf7c1375
https://hg.mozilla.org/mozilla-central/rev/de9898be5bbe
https://hg.mozilla.org/mozilla-central/rev/6d0193a41ab4
https://hg.mozilla.org/mozilla-central/rev/b425ca25edc5
https://hg.mozilla.org/mozilla-central/rev/151f1392f619

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15999 for changes under testing/web-platform/tests

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 20

[Eric Shepherd [:sheppy]]

Documentation has been updated:

• Updated RTCPeerConnection.addIceCandidate()

• Updated RTCIceCandidate.candidate

• Updated RTCIceCandidate()

• Updated RTCIceCandidateInit.candidate

• Updated WebRTC connectivity

• Updated RTCPeerConnection.onicecandidate

• Updated RTCPeerConnectionIceEvent

• Updated RTCPeerConnectionIceEvent.candidate

• Updated Firefox 68 for developers.

Please look this stuff over and if you see any problems, feel free to edit the articles directly or ping me here or in email with recommended changes.