Closed Bug 1318167 Opened 7 years ago Closed 5 years ago

Add support for ICE end of candidate


(Core :: WebRTC: Networking, defect, P2)




Tracking Status
firefox53 --- wontfix
firefox68 --- fixed


(Reporter: drno, Assigned: bwc)


(Blocks 2 open bugs, )


(Keywords: dev-doc-complete)


(5 files)

The current spec allows the end of candidates null candidate to passed into addIceCandidate().
We need to add support for the in nICEr and then expose it via the JS API.
Update: now says addIceCandidate needs to support empty string to mean end of candidate gathering.

We also need to update the onicecandidate side to follow the spec [1] which says to emit such a candidate ahead of the existing null canddidate, as mentioned here [2]:

  "Create an RTCIceCandidate instance newCandidate, with sdpMid and sdpMLineIndex set to the values associated with this RTCIceTransport , with ufrag set to the ufrag of the generation of candidates for which gathering finished, with candidate set to an empty string"

Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Once this is fixed, addIceCandidate should no longer allow null as a candidate argument.
Rank: 21 → 18
Priority: P3 → P2
Assignee: nobody → docfaraday

There's a spec bug that needs to be worked out here:

Made a PR here:

Going to have to jump through some hoops before it can be merged.

Attachment #9050452 - Attachment description: Bug 1318167 - Part 2: Incorporate remote end-of-candidates into SDP. → Bug 1318167 - Part 4: Incorporate remote end-of-candidates into SDP.
Blocks: 1535690
Pushed by
Part 0: Re-enable some test-cases. r=jib
Part 1: Give RTCIceCandidateInit.candidate a default value. r=smaug,jib
Part 2: Several test fixes that webidl changes highlighted, plus suppressions for tests that were succeeding for the wrong reasons. r=jib
Part 3: Add some testing for a=end-of-candidates in remote SDP. r=jib
Part 4: Incorporate remote end-of-candidates into SDP. r=mjf
Created web-platform-tests PR for changes under testing/web-platform/tests

Documentation has been updated:

Please look this stuff over and if you see any problems, feel free to edit the articles directly or ping me here or in email with recommended changes.

Regressions: 1566095
You need to log in before you can comment on or make changes to this bug.