Add support for ICE end of candidate
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
People
(Reporter: drno, Assigned: bwc)
References
(Blocks 2 open bugs, )
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
The current spec allows the end of candidates null candidate to passed into addIceCandidate(). We need to add support for the in nICEr and then expose it via the JS API.
Updated•7 years ago
|
Comment 1•6 years ago
|
||
Update: http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate now says addIceCandidate needs to support empty string to mean end of candidate gathering. We also need to update the onicecandidate side to follow the spec [1] which says to emit such a candidate ahead of the existing null canddidate, as mentioned here [2]: "Create an RTCIceCandidate instance newCandidate, with sdpMid and sdpMLineIndex set to the values associated with this RTCIceTransport , with ufrag set to the ufrag of the generation of candidates for which gathering finished, with candidate set to an empty string" [1] http://w3c.github.io/webrtc-pc/#rtcicetransport [2] https://github.com/w3c/webrtc-pc/issues/1213#issuecomment-301861839
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Mass change P2->P3 to align with new Mozilla triage process.
Comment 3•6 years ago
|
||
Once this is fixed, addIceCandidate should no longer allow null as a candidate argument.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
There's a spec bug that needs to be worked out here:
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D23219
Assignee | ||
Comment 8•5 years ago
|
||
Made a PR here: https://github.com/w3c/webrtc-pc/pull/2127
Going to have to jump through some hoops before it can be merged.
Assignee | ||
Comment 9•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b01315bb432ea1c9c9afa32f0f1ae9eee3a6ff
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D23219
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D23590
Updated•5 years ago
|
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0b06d9947b99cc828303bd5b3270c26485d45d3
Assignee | ||
Comment 14•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a06608b89846ef6e1f94517b4539310636c72a4f
Assignee | ||
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e71abf7c1375 Part 0: Re-enable some test-cases. r=jib https://hg.mozilla.org/integration/autoland/rev/de9898be5bbe Part 1: Give RTCIceCandidateInit.candidate a default value. r=smaug,jib https://hg.mozilla.org/integration/autoland/rev/6d0193a41ab4 Part 2: Several test fixes that webidl changes highlighted, plus suppressions for tests that were succeeding for the wrong reasons. r=jib https://hg.mozilla.org/integration/autoland/rev/b425ca25edc5 Part 3: Add some testing for a=end-of-candidates in remote SDP. r=jib https://hg.mozilla.org/integration/autoland/rev/151f1392f619 Part 4: Incorporate remote end-of-candidates into SDP. r=mjf
Comment 17•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e71abf7c1375
https://hg.mozilla.org/mozilla-central/rev/de9898be5bbe
https://hg.mozilla.org/mozilla-central/rev/6d0193a41ab4
https://hg.mozilla.org/mozilla-central/rev/b425ca25edc5
https://hg.mozilla.org/mozilla-central/rev/151f1392f619
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15999 for changes under testing/web-platform/tests
Upstream PR merged
Updated•5 years ago
|
Comment 20•5 years ago
|
||
Documentation has been updated:
-
Updated RTCIceCandidate.candidate
-
Updated RTCIceCandidate()
-
Updated RTCIceCandidateInit.candidate
-
Updated WebRTC connectivity
-
Updated RTCPeerConnection.onicecandidate
-
Updated RTCPeerConnectionIceEvent
-
Updated Firefox 68 for developers.
Please look this stuff over and if you see any problems, feel free to edit the articles directly or ping me here or in email with recommended changes.
Description
•