1318189 - ./mach configure doesn't detect MFC when using VS15 preview / 2017

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

Directory structure is changed from VS15(2017) Preview.  So we don't detect MFC correctly.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1318189 - mach configure cannot detect MFC library path on VS2017.

VS2017's directory structure for mfc is the following.

 Directory of C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\vc\Tools\msvc\14.10.24629\atlmfc\lib

2016/11/21  13:57    <DIR>          .
2016/11/21  13:57    <DIR>          ..
2016/11/21  13:57    <DIR>          arm
2016/11/21  14:00    <DIR>          x64
2016/11/21  13:59    <DIR>          x86

So this structure is changed, we cannot detect mfc when using VS2017.

Review commit: https://reviewboard.mozilla.org/r/94310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94310/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8812652 [details]
Bug 1318189 - mach configure cannot detect MFC library path on VS2017.

https://reviewboard.mozilla.org/r/94310/#review95162

::: build/moz.configure/windows.configure:342
(Diff revision 1)
>      if not os.path.isdir(atlmfc_dir):
> -        die('Cannot find the ATL/MFC libraries in the Visual C++ directory (%s). '
> -            'Please install them.' % vc_path)
> +        # For Visual Studio 2017
> +        atlmfc_dir = os.path.join(vc_path, 'atlmfc', 'lib', sdk_target)
> +        if not os.path.isdir(atlmfc_dir):
> +            die('Cannot find the ATL/MFC libraries in the Visual C++ directory'
> +                ' (%s). Please install them.' % vc_path)

Please move the space to the end of previous line.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53a9ff4a083a
mach configure cannot detect MFC library path on VS2017. r=glandium

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/53a9ff4a083a