./mach configure doesn't detect MFC when using VS15 preview / 2017

RESOLVED FIXED in Firefox 53

Status

RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

unspecified
mozilla53

Firefox Tracking Flags

(firefox53 fixed)

Details

(URL)

Attachments

(1 attachment)

Directory structure is changed from VS15(2017) Preview.  So we don't detect MFC correctly.
Assignee: nobody → m_kato
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8812652 [details]
Bug 1318189 - mach configure cannot detect MFC library path on VS2017.

https://reviewboard.mozilla.org/r/94310/#review95162

::: build/moz.configure/windows.configure:342
(Diff revision 1)
>      if not os.path.isdir(atlmfc_dir):
> -        die('Cannot find the ATL/MFC libraries in the Visual C++ directory (%s). '
> -            'Please install them.' % vc_path)
> +        # For Visual Studio 2017
> +        atlmfc_dir = os.path.join(vc_path, 'atlmfc', 'lib', sdk_target)
> +        if not os.path.isdir(atlmfc_dir):
> +            die('Cannot find the ATL/MFC libraries in the Visual C++ directory'
> +                ' (%s). Please install them.' % vc_path)

Please move the space to the end of previous line.
Attachment #8812652 - Flags: review?(mh+mozilla) → review+

Comment 3

2 years ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53a9ff4a083a
mach configure cannot detect MFC library path on VS2017. r=glandium

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/53a9ff4a083a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.