131820 - Hitting return in an inline style doesn't advance caret to next line

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[kinmoz]

I noticed this bug while trying to fix bug 102615 ...

To reproduce:

1. Startup a new composer window.
2. Type a letter.
3. Hit backspace.
4. Hit the bold button on the toolbar.
5. Type a letter.
6. Hit return.

Notice how the caret fails to go to the next line?

If you follow the steps above, but leave out steps 2 and 3, things work fine.

The problem is that whenever we delete enough content to make the body empty, 
nsHTMLEditRules::AdjustSelection() adds a mozBR before AfterEditInner() can call 
CreateBogusNodeIfNeeded() ... why does it matter what type of BR we add? Because 
IsVisBreak() as well as other editor methods call IsEditable() which checks 
specifically for br bogus nodes which are considered not-editable.

Comment 1

[kinmoz]

Attachment: Patch Rev 1 (Prevent AdjustSelection() from adding a MozBR when body is empty)

Comment 2

[Joe Francis]

Comment on attachment 74802 [details] [diff] [review]
Patch Rev 1 (Prevent AdjustSelection() from adding a MozBR when body is empty)

r=jfrancis

Comment 3

[Kevin McCluskey (gone)]

nsbeta1+

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 74802 [details] [diff] [review]
Patch Rev 1 (Prevent AdjustSelection() from adding a MozBR when body is empty)

sr=sfraser

Comment 5

[Scott Collins]

Comment on attachment 74802 [details] [diff] [review]
Patch Rev 1 (Prevent AdjustSelection() from adding a MozBR when body is empty)

a=scc

Comment 6

[kinmoz]

Fix checked in on TRUNK:

    mozilla/editor/libeditor/html/nsHTMLEditRules.cpp  revision 1.236

Comment 7

[sujay]

verified in 3/20 build.