Open Bug 1318221 Opened 8 years ago Updated 2 years ago

Enable resource-selection-pointer-insert-source.html, resource-selection-pointer-remove-source.html resource-selection-source-media.html

Categories

(Testing :: web-platform-tests, defect)

defect

Tracking

(Not tracked)

REOPENED

People

(Reporter: ctai, Unassigned)

References

(Depends on 1 open bug)

Details

Enable resource-selection-pointer-insert-source.html, resource-selection-pointer-remove-source.html resource-selection-source-media.html
Component: Audio/Video: Playback → web-platform-tests
Product: Core → Testing
I think this bug is duplicated of bug 1318196. Can you confirm that? Once the stableState is fired right after the </video>, then the behavior should be right.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jwwang)
Flags: needinfo?(bugs)
Resolution: --- → DUPLICATE
This bug is not a dup of bug 1318196. This bug is about enabling some tests which can be done only after bug 1318196 is fixed.
Status: RESOLVED → REOPENED
Depends on: 1318196
Flags: needinfo?(jwwang)
Resolution: DUPLICATE → ---
Flags: needinfo?(bugs)
Depends on: 1325053
See https://github.com/w3c/web-platform-tests/issues/4376
resource-selection-pointer-insert-source.html and resource-selection-pointer-remove-source.html are racy test.

Try result after commented out the racy assert x2:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40f5287084300857d637fa00c8acb0b0d022552f

Again, those tests are all depended on bug 1318196, above try result also includes the work around solution(XHR) for testing media related codes.

Samug, what do you think? Should we land a work around modified test?
Flags: needinfo?(bugs)
JW, what do you think?
Flags: needinfo?(jwwang)
So for resource-selection-pointer-remove-source.html at least we should wait for the test to be fixed in W3C wpt.

And we should never land the XHR workaround. That workaround is just something which hints us that some 
issues we have with certain media tests are because of bug 1318196.
Flags: needinfo?(bugs)
(In reply to Olli Pettay [:smaug] from comment #5)
> So for resource-selection-pointer-remove-source.html at least we should wait
> for the test to be fixed in W3C wpt.
> 
> And we should never land the XHR workaround. That workaround is just
> something which hints us that some 
> issues we have with certain media tests are because of bug 1318196.

http://searchfox.org/mozilla-central/rev/4f5f9f3222f35fa4635ea96a0c963c130854ef19/testing/web-platform/README.md#69
The changes will be upstreamed automatically.

I think the plan is:
1. Fix bug 1318196.
2. Fix resource-selection-pointer-remove-source.html and the change will be uplifted to the web-platform-tests repo.
3. Or wait for someone to fix resource-selection-pointer-remove-source.html in the web-platform-tests repo and the change will be synced to our repo.

I would prefer 1+2.
Flags: needinfo?(jwwang)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.