Closed
Bug 1318222
Opened 8 years ago
Closed 8 years ago
Adding tests to Fennec
Categories
(Firefox for Android Graveyard :: Testing, defect, P3)
Firefox for Android Graveyard
Testing
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: cnevinchen, Assigned: cnevinchen)
Details
Attachments
(2 files, 1 obsolete file)
Target : Learn to add one UI Test and one Unit Test to Fennec.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811647 [details] Bug 1318222 - Add a unit test https://reviewboard.mozilla.org/r/93686/#review94062 ::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/util/TestFloatUtils.java:1 (Diff revision 1) > +package org.mozilla.gecko.util; nit: License header is missing. You can copy that from another file in this package. ::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/util/TestFloatUtils.java:60 (Diff revision 1) > + > + nit: Some empty lines at the bottom
Attachment #8811647 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811648 [details] Bug 1318222 - Updated the unit test,added more test https://reviewboard.mozilla.org/r/93688/#review94064
Attachment #8811648 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811649 [details] Bug 1318222 - Add a UI test https://reviewboard.mozilla.org/r/93690/#review94066 Our tests in automation do not have (and should not) access resources on the internet. Every web page we want to load during test needs to be part of the test package and can be loaded using the NavigationHelper class (to build the URL).
Attachment #8811649 -
Flags: review?(s.kaspari) → review-
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Priority: -- → P3
|
|
||
Updated•8 years ago
|
Assignee: nobody → cnevinchen
Status: NEW → ASSIGNED
|
|
||
Comment 10•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811649 [details] Bug 1318222 - Add a UI test https://reviewboard.mozilla.org/r/93690/#review94480 I'm not sure if this is a good UI test to run in automation (This is mostly testing the icon code and we have a bunch of unit tests for that) - However as you just wanted to learn to write some tests - maybe just land the first two patches and move on?
Attachment #8811649 -
Flags: review?(s.kaspari)
|
Assignee | |
Updated•8 years ago
|
Attachment #8811649 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•8 years ago
|
||
Sure! I just reset to previous commit. Is that okay?
Flags: needinfo?(s.kaspari)
|
|
||
Comment 12•8 years ago
|
||
Yeah, let's run this on try and then land this. :)
Flags: needinfo?(s.kaspari)
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 13•8 years ago
|
||
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16b1dec1956f Add a unit test r=sebastian https://hg.mozilla.org/integration/autoland/rev/5aa4b8d98078 Updated the unit test,added more test r=sebastian
Keywords: checkin-needed
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/16b1dec1956f https://hg.mozilla.org/mozilla-central/rev/5aa4b8d98078
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•