1318222 - Adding tests to Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Nevin Chen(Not active on Bugzilla)]

Target : Learn to add one UI Test and one Unit Test to Fennec.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1318222 - Add a unit test

Review commit: https://reviewboard.mozilla.org/r/93686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93686/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1318222 - Updated the unit test,added more test

Review commit: https://reviewboard.mozilla.org/r/93688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93688/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1318222 - Add a UI test

Review commit: https://reviewboard.mozilla.org/r/93690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93690/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811647 [details]
Bug 1318222 - Add a unit test

https://reviewboard.mozilla.org/r/93686/#review94062

::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/util/TestFloatUtils.java:1
(Diff revision 1)
> +package org.mozilla.gecko.util;

nit: License header is missing. You can copy that from another file in this package.

::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/util/TestFloatUtils.java:60
(Diff revision 1)
> +
> +

nit: Some empty lines at the bottom

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811648 [details]
Bug 1318222 - Updated the unit test,added more test

https://reviewboard.mozilla.org/r/93688/#review94064

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811649 [details]
Bug 1318222 - Add a UI test

https://reviewboard.mozilla.org/r/93690/#review94066

Our tests in automation do not have (and should not) access resources on the internet. Every web page we want to load during test needs to be part of the test package and can be loaded using the NavigationHelper class (to build the URL).

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8811647 [details]
Bug 1318222 - Add a unit test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93686/diff/1-2/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8811648 [details]
Bug 1318222 - Updated the unit test,added more test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93688/diff/1-2/

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8811649 [details]
Bug 1318222 - Add a UI test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93690/diff/1-2/

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811649 [details]
Bug 1318222 - Add a UI test

https://reviewboard.mozilla.org/r/93690/#review94480

I'm not sure if this is a good UI test to run in automation (This is mostly testing the icon code and we have a bunch of unit tests for that) - However as you just wanted to learn to write some tests - maybe just land the first two patches and move on?

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Sure!
I just reset to previous commit. Is that okay?

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

Yeah, let's run this on try and then land this. :)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b1dec1956f
Add a unit test r=sebastian
https://hg.mozilla.org/integration/autoland/rev/5aa4b8d98078
Updated the unit test,added more test r=sebastian

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16b1dec1956f
https://hg.mozilla.org/mozilla-central/rev/5aa4b8d98078