1318225 - Remove demux-only related API and the test case.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[James Cheng[:JamesCheng]]

This bug is to remove the work of Bug 1194606.

Since the original design is for B2G external rendering usage but it is no longer needed.

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1318225 - Part1 - Remove Test Case.

Review commit: https://reviewboard.mozilla.org/r/93672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93672/

Comment 3

[James Cheng[:JamesCheng]]

Attachment: Bug 1318225 - Part2 - Remove demux-only APIs.

Review commit: https://reviewboard.mozilla.org/r/93674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93674/

Comment 4

[James Cheng[:JamesCheng]]

Try result:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6df888990f2690a698b6a19087f66622d8d4208c

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8811614 [details]
Bug 1318225 - Part1 - Remove Test Case.

https://reviewboard.mozilla.org/r/93672/#review93740

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8811615 [details]
Bug 1318225 - Part2 - Remove demux-only APIs.

https://reviewboard.mozilla.org/r/93674/#review93742

::: dom/media/MediaDecoderStateMachine.h
(Diff revision 1)
>    // Returns true if we're currently playing. The decoder monitor must
>    // be held.
>    bool IsPlaying() const;
>  
> -  // TODO: Those callback function may receive demuxed-only data.
> -  // Need to figure out a suitable API name for this case.

Those were changed so it would no longer return AudioData or VideoData and instead the base type MediaData

this has lead to having no unecessary checks if the type returned.

please change back those API as they were before demux only mode was introduced and all checks related

Comment 7

[James Cheng[:JamesCheng]]

Thank you.  I will revert the work on Bug 1203047.

Comment 8

[James Cheng[:JamesCheng]]

Comment on attachment 8811614 [details]
Bug 1318225 - Part1 - Remove Test Case.

https://reviewboard.mozilla.org/r/93670/#review94444

The intention of Bug 1203047 is to make code abstracted, so I think we should keep the MediaData* instead of VideoData*/AudioData* for data passing.

For data abstraction,  I will not revert the MediaDataPromise to Video/AudioDataPromise. 

Removing the unnecessary parameter.

Thanks.

Comment 9

[James Cheng[:JamesCheng]]

Comment on attachment 8811614 [details]
Bug 1318225 - Part1 - Remove Test Case.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93672/diff/1-2/

Comment 10

[James Cheng[:JamesCheng]]

Comment on attachment 8811615 [details]
Bug 1318225 - Part2 - Remove demux-only APIs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93674/diff/1-2/

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8811615 [details]
Bug 1318225 - Part2 - Remove demux-only APIs.

https://reviewboard.mozilla.org/r/93674/#review94776

Comment 12

[James Cheng[:JamesCheng]]

Comment on attachment 8811614 [details]
Bug 1318225 - Part1 - Remove Test Case.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93672/diff/2-3/

Comment 13

[James Cheng[:JamesCheng]]

Comment on attachment 8811615 [details]
Bug 1318225 - Part2 - Remove demux-only APIs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93674/diff/2-3/

Comment 14

[James Cheng[:JamesCheng]]

Thank you for review. Rebased the patch

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7014315bb46f
Part1 - Remove Test Case. r=jya
https://hg.mozilla.org/integration/autoland/rev/3a4c4f69e179
Part2 - Remove demux-only APIs. r=jya

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7014315bb46f
https://hg.mozilla.org/mozilla-central/rev/3a4c4f69e179