Closed Bug 1318273 Opened 8 years ago Closed 8 years ago

Improve the use of SpecialPowers.pushPrefEnv()

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

In many tests we have this pattern:

{yield/return}
new Promise(r => SpecialPowers.pushPrefEnv({set:
  [[something, value]]}, r));

But pushPrefEnv returns a promise, so we can simply do:

{yield/return}
SpecialPowers.pushPrefEnv({set: [[something, value]]});
Attachment #8811641 - Flags: review?(kyle)
Attachment #8811642 - Flags: review?(kyle)
Attachment #8811641 - Attachment description: pushPref.patch → part 1 - pushPrevEnv
Attachment #8811641 - Flags: review?(kyle) → review+
Attachment #8811642 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d43b778d95c6
Improve the use of SpecialPowers.pushPrefEnv() - part 1, r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/2560659cda95
Improve the use of SpecialPowers.pushPrefEnv() - part 2, r=qdot
Backed out for failing mochitest fetch/test_formdataparsing.html:

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8b332856a283132dcb867d0c57ded440ce07ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8b332856a283132dcb867d0c57ded440ce07ac

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2560659cda95386dcbca643ee2a8d2bea3e68dd6
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=39395479&repo=mozilla-inbound

11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | Expected test to be valid FormData for 1234567891011121314151617
11:41:43     INFO - Content-Disposition: form-data; name="file"; filename="xml.txt"
11:41:43     INFO - content-type       : application/xml
11:41:43     INFO - 
11:41:43     INFO - <body>foobar
11:41:43     INFO - 
11:41:43     INFO - </body>
11:41:43     INFO - 1234567891011121314151617- 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | Entry with filename attribute should be read as File. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | Filename should match. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | content-type should be application/xml. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should be empty. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should be empty. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should be empty. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should be empty. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should have correct text. 
11:41:43     INFO - TEST-PASS | dom/tests/mochitest/fetch/test_formdataparsing.html | File should have correct text. 
11:41:43     INFO - Buffered messages finished
11:41:43     INFO - TEST-UNEXPECTED-TIMEOUT | dom/tests/mochitest/fetch/test_formdataparsing.html | application timed out after 330 seconds with no output
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a229803174c3
Improve the use of SpecialPowers.pushPrefEnv() - part 1, r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/671f0ae143a2
Improve the use of SpecialPowers.pushPrefEnv() - part 2, r=qdot
https://hg.mozilla.org/mozilla-central/rev/a229803174c3
https://hg.mozilla.org/mozilla-central/rev/671f0ae143a2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(amarchesini)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: