Closed
Bug 1318276
Opened 9 years ago
Closed 9 years ago
Clean up CustomizableUIInternal.addShortcut
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
- set parameter default instead of 'if (!aTargetNode) aTargetNode = aShortcutNode'
- remove the !aTargetNode null-check. It's ineffective since aShortcutNode.ownerDocument would already throw (which I don't think is a bad thing)
- move let document declaration down to where it's needed (this means that aTargetNode.hasAttribute could throw now, which again I don't think is a problem)
Attachment #8811651 -
Flags: review?(jaws)
|
||
Updated•9 years ago
|
Attachment #8811651 -
Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/115aceed9fdd
Clean up CustomizableUIInternal.addShortcut. r=jaws
|
||
Comment 2•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•