Closed Bug 1318276 Opened 5 years ago Closed 5 years ago
Clean up Customizable
UIInternal .add Shortcut
- set parameter default instead of 'if (!aTargetNode) aTargetNode = aShortcutNode' - remove the !aTargetNode null-check. It's ineffective since aShortcutNode.ownerDocument would already throw (which I don't think is a bad thing) - move let document declaration down to where it's needed (this means that aTargetNode.hasAttribute could throw now, which again I don't think is a problem)
Attachment #8811651 - Flags: review?(jaws)
Attachment #8811651 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/115aceed9fdd Clean up CustomizableUIInternal.addShortcut. r=jaws
You need to log in before you can comment on or make changes to this bug.