1318299 - Convert some code in security/manager to C++11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators

Comment 1

[Andi [:andi]]

Attachment: Bug 1318299 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in security/manager.

Review commit: https://reviewboard.mozilla.org/r/93706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93706/

Comment 2

[Andi [:andi]]

Attachment: Bug 1318299 - Replace string literals containing escaped characters with raw string literals in security/manager.

Review commit: https://reviewboard.mozilla.org/r/93708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93708/

Comment 3

[Andi [:andi]]

Attachment: Bug 1318299 - Use C++11's override and remove virtual where applicable in security/manager.

Review commit: https://reviewboard.mozilla.org/r/93710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93710/

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8811681 [details]
Bug 1318299 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in security/manager.

https://reviewboard.mozilla.org/r/93706/#review93934

::: security/manager/ssl/tests/unit/tlsserver/cmd/GenerateOCSPResponse.cpp:80
(Diff revision 1)
>                           /*out*/ OCSPResponseType* OCSPType)
>  {
>    if (!OCSPType) {
>      return false;
>    }
> -  for (uint32_t i = 0; i < mozilla::ArrayLength(kOCSPResponseNameList); i++) {
> +  for (auto i : kOCSPResponseNameList) {

'i' isn't very descriptive. Let's maybe use 'ocspResponseName' to reflect the underlying type.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8811682 [details]
Bug 1318299 - Replace string literals containing escaped characters with raw string literals in security/manager.

https://reviewboard.mozilla.org/r/93708/#review93964

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8811683 [details]
Bug 1318299 - Use C++11's override and remove virtual where applicable in security/manager.

https://reviewboard.mozilla.org/r/93710/#review93968

Great - thanks!

Comment 7

[Andi [:andi]]

Comment on attachment 8811681 [details]
Bug 1318299 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in security/manager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93706/diff/1-2/

Comment 8

[Andi [:andi]]

Comment on attachment 8811682 [details]
Bug 1318299 - Replace string literals containing escaped characters with raw string literals in security/manager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93708/diff/1-2/

Comment 9

[Andi [:andi]]

Comment on attachment 8811683 [details]
Bug 1318299 - Use C++11's override and remove virtual where applicable in security/manager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93710/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fad88b953cc
Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in security/manager. r=keeler
https://hg.mozilla.org/integration/autoland/rev/beeffee0c4ee
Replace string literals containing escaped characters with raw string literals in security/manager. r=keeler
https://hg.mozilla.org/integration/autoland/rev/1c1707b6cef5
Use C++11's override and remove virtual where applicable in security/manager. r=keeler

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9fad88b953cc
https://hg.mozilla.org/mozilla-central/rev/beeffee0c4ee
https://hg.mozilla.org/mozilla-central/rev/1c1707b6cef5

Comment 12

[areya]

https://hg.mozilla.org/mozilla-central/rev/9fad88b953cc
https://hg.mozilla.org/mozilla-central/rev/beeffee0c4ee
https://hg.mozilla.org/mozilla-central/rev/1c1707b6cef5