1318371 - JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/ExtensionContent.jsm" line: 897}

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

I see this when running tests locally.

http://searchfox.org/mozilla-central/rev/62db1c9021cfbde9fa5e6e9601de16c21f4c7ce4/toolkit/components/extensions/ExtensionContent.jsm#894-900

>      case "Extension:FlushJarCache": {
>        let nsIFile = Components.Constructor("@mozilla.org/file/local;1", "nsIFile",
>                                             "initWithPath");
>        let file = new nsIFile(data.path);
>        flushJarCache(file);
>        Services.cpmm.sendAsyncMessage("Extension:FlushJarCacheComplete");
>        break;
>      }

Comment 1

[Kris Maglione [:kmag]]

Yeah, I've been meaning to fix this for a while. Unfortunately, the only way to do it is to change that observer to accept something other than a nsIFile.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1318371: Flush jar caches by path rather than creating a nsIFile in the content process.

Review commit: https://reviewboard.mozilla.org/r/93974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93974/

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8812058 [details]
Bug 1318371: Flush jar caches by path rather than creating a nsIFile in the content process.

https://reviewboard.mozilla.org/r/93974/#review94338

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4703e33bc324a75c325b9a17e3c0e58d18ea440
Bug 1318371: Flush jar caches by path rather than creating a nsIFile in the content process. r=billm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4703e33bc32