Closed
Bug 1318476
Opened 9 years ago
Closed 9 years ago
Remove some unused XPIDL nsIDOMNode bits
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
17.11 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Various things here are not called anywhere in our code, and it's not scriptable, and we no longer support binary addons.
|
Assignee | |
Comment 1•9 years ago
|
||
I hope I understood things correctly in terms of the issues from bug 1078674 not coming back to bite us...
Attachment #8812081 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Benjamin, is my understanding correct that we don't have to worry about problems like bug 1078674 anymore?
Flags: needinfo?(benjamin)
|
||
Comment 3•9 years ago
|
||
For 53 yes I'm confident that we won't have to think about that any more.
Flags: needinfo?(benjamin)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8812081 [details] [diff] [review]
Remove various unused nsIDOMNode stuff
Review of attachment 8812081 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/interfaces/core/nsIDOMNode.idl
@@ -68,5 @@
>
> // Introduced in DOM Level 2:
> readonly attribute DOMString localName;
>
> - // For vtable compatibility (see bug 1078674)
What an enjoyable bug.
Attachment #8812081 -
Flags: review?(nfroyd) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d91cd7bec126
Remove various unused nsIDOMNode stuff. r=froydnj
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•