Closed Bug 1318476 Opened 5 years ago Closed 5 years ago

Remove some unused XPIDL nsIDOMNode bits

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Remove various unused nsIDOMNode stuff
17.11 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Various things here are not called anywhere in our code, and it's not scriptable, and we no longer support binary addons.
Depends on: 1318479
I hope I understood things correctly in terms of the issues from bug 1078674 not coming back to bite us...
Attachment #8812081 - Flags: review?(nfroyd)
Benjamin, is my understanding correct that we don't have to worry about problems like bug 1078674 anymore?
Flags: needinfo?(benjamin)
For 53 yes I'm confident that we won't have to think about that any more.
Flags: needinfo?(benjamin)
Comment on attachment 8812081 [details] [diff] [review]
Remove various unused nsIDOMNode stuff

Review of attachment 8812081 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/core/nsIDOMNode.idl
@@ -68,5 @@
>  
>    // Introduced in DOM Level 2:
>    readonly attribute DOMString        localName;
>  
> -  // For vtable compatibility (see bug 1078674)

What an enjoyable bug.
Attachment #8812081 - Flags: review?(nfroyd) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d91cd7bec126
Remove various unused nsIDOMNode stuff.  r=froydnj
https://hg.mozilla.org/mozilla-central/rev/d91cd7bec126
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.