Remove some unused XPIDL nsIDOMNode bits

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Various things here are not called anywhere in our code, and it's not scriptable, and we no longer support binary addons.
Depends on: 1318479
Created attachment 8812081 [details] [diff] [review]
Remove various unused nsIDOMNode stuff

I hope I understood things correctly in terms of the issues from bug 1078674 not coming back to bite us...
Attachment #8812081 - Flags: review?(nfroyd)
Benjamin, is my understanding correct that we don't have to worry about problems like bug 1078674 anymore?
Flags: needinfo?(benjamin)

Comment 3

11 months ago
For 53 yes I'm confident that we won't have to think about that any more.
Flags: needinfo?(benjamin)

Comment 4

11 months ago
Comment on attachment 8812081 [details] [diff] [review]
Remove various unused nsIDOMNode stuff

Review of attachment 8812081 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/core/nsIDOMNode.idl
@@ -68,5 @@
>  
>    // Introduced in DOM Level 2:
>    readonly attribute DOMString        localName;
>  
> -  // For vtable compatibility (see bug 1078674)

What an enjoyable bug.
Attachment #8812081 - Flags: review?(nfroyd) → review+

Comment 5

11 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d91cd7bec126
Remove various unused nsIDOMNode stuff.  r=froydnj

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d91cd7bec126
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.