1318488 - [mozlint] Use sys.stdout.encoding when printing formatter output

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Andrew Halberstadt [:ahal]]

Mark was hitting a UnicodeDecodeError on windows. He figured out that:
https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/cli.py#105

Should be something like "sys.stdout.encoding or 'ascii'" instead. This fixed the issue for him and I verified it on Linux as well.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output,

This fixes a UnicodeDecodeError when sys.stdout's encoding can't handle unicode.

Review commit: https://reviewboard.mozilla.org/r/93824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93824/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Thanks! I put a slightly different patch up in bug 1318496 - I'll flag Steven for review on that too, then he can choose which one he likes better and close the other as a dupe :)

Comment 3

[Steven MacLeod [:smacleod]]

Comment on attachment 8811948 [details]
Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output,

https://reviewboard.mozilla.org/r/93824/#review94660

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8811948 [details]
Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output,

https://reviewboard.mozilla.org/r/93824/#review94660

Bah, meant to say you might want to update the comment above things a bit though before landing, as it's not as accurate anymore.

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8811948 [details]
Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93824/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43556298f164
[mozlint] Use sys.stdout.encoding when printing formatter's output, r=smacleod

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43556298f164