1318494 - Bug 1316450 breaks IPDL unit tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

When I build with --enable-ipdl-tests, I see:

 0:31.24 ==============================
 0:31.24 ERROR PROCESSING MOZBUILD FILE
 0:31.24 ==============================
 0:31.24 
 0:31.24 The error occurred while processing the following file or one of the files it includes:
 0:31.24 
 0:31.24     /workspace/billm/gecko/ipc/ipdl/test/cxx/app/moz.build
 0:31.24 
 0:31.24 The error occurred when validating the result of the execution. The reported error is:
 0:31.24 
 0:31.24     ipdlunittest depends on the XPCOM glue. No new dependency on the XPCOM glue is allowed.

Comment 1

[Andrew McCreight [:mccr8]]

I think all that needs to be done here is to add another entry to the ALLOWED_XPCOM_GLUE list. The IPDL unit tests are about 6 years old, so I'm sure they fit in the spirit of bug 1316450. I'll get glandium to review.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1318494 - Add IPDL unit tests to ALLOWED_XPCOM_GLUE.

Review commit: https://reviewboard.mozilla.org/r/94782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94782/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8813362 [details]
Bug 1318494 - Add IPDL unit tests to ALLOWED_XPCOM_GLUE.

https://reviewboard.mozilla.org/r/94782/#review95070

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31a06ae32d3b
Add IPDL unit tests to ALLOWED_XPCOM_GLUE. r=glandium

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/31a06ae32d3b