Closed Bug 1318494 Opened 4 years ago Closed 4 years ago

Bug 1316450 breaks IPDL unit tests

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: billm, Assigned: mccr8)

References

Details

Attachments

(1 file)

When I build with --enable-ipdl-tests, I see:

 0:31.24 ==============================
 0:31.24 ERROR PROCESSING MOZBUILD FILE
 0:31.24 ==============================
 0:31.24 
 0:31.24 The error occurred while processing the following file or one of the files it includes:
 0:31.24 
 0:31.24     /workspace/billm/gecko/ipc/ipdl/test/cxx/app/moz.build
 0:31.24 
 0:31.24 The error occurred when validating the result of the execution. The reported error is:
 0:31.24 
 0:31.24     ipdlunittest depends on the XPCOM glue. No new dependency on the XPCOM glue is allowed.
I think all that needs to be done here is to add another entry to the ALLOWED_XPCOM_GLUE list. The IPDL unit tests are about 6 years old, so I'm sure they fit in the spirit of bug 1316450. I'll get glandium to review.
Assignee: nobody → continuation
Comment on attachment 8813362 [details]
Bug 1318494 - Add IPDL unit tests to ALLOWED_XPCOM_GLUE.

https://reviewboard.mozilla.org/r/94782/#review95070
Attachment #8813362 - Flags: review?(mh+mozilla) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31a06ae32d3b
Add IPDL unit tests to ALLOWED_XPCOM_GLUE. r=glandium
https://hg.mozilla.org/mozilla-central/rev/31a06ae32d3b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.