1318515 - Incremental sync follow up: database-backed bookmarks buffer

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[:Grisha Kruglov]

Bug 1291821 does the legwork necessary to make adding a db-backed bookmarks buffer fairly straightforward.

Rough overview:
- Add bookmark buffer table
- Add a bookmark-record aware DatabaseBufferStorage implementation
- Teach SyncProvider how to store bookmark records into a buffer
- Write tests for all of the above
- Get BookmarkSyncStage to request BufferingMiddleware that the above BufferStorage is used

See https://reviewboard.mozilla.org/r/85408/diff/9#index_header for reference, which adds a db-backed buffer for history.

Additional work we might consider doing as part of this bug (or separately):
- improve how bookmark records are inserted into live storage during sync, with focus on perf and making the whole thing as atomic as possible. Similar to improvements made for history bulk insertions from sync: https://reviewboard.mozilla.org/r/85084/diff/10#index_header

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.