Closed Bug 1318523 Opened 5 years ago Closed 5 years ago
Unify VAO object types
We have two different webidl types right now. We should only need one. The implementation for the WebGL 1 extension already calls into the webgl2 entrypoints, so that part is already unified.
Comment on attachment 8812004 [details] Bug 1318523 - Unify VAO implementation. - https://reviewboard.mozilla.org/r/93888/#review94112
Attachment #8812004 - Flags: review?(ethlin) → review+
Comment on attachment 8812003 [details] Bug 1318523 - Remove removed class from test_interfaces. - https://reviewboard.mozilla.org/r/93886/#review94244
Attachment #8812003 - Flags: review?(kyle) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a4efff3270cc Unify VAO idl. - r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/e63177dc8159 Unify VAO implementation. - r=ethlin
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7daa2b41dae Remove removed class from test_interfaces. - r=qdot CLOSED TREE
Attachment #8812004 - Attachment is obsolete: true
Approval Request Comment [Feature/Bug causing the regression]: webgl2 [User impact if declined]: [Is this code covered by automated tests?]: [Has the fix been verified in Nightly?]: [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: [Is the change risky?]: [Why is the change risky/not risky?]: [String changes made/needed]:
Attachment #8812003 - Attachment is obsolete: true
Comment on attachment 8818745 [details] placeholder for all patches WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.
Redirected https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObjectOES to https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObject Updated reference docs to mention WebGLVertexArrayObject instead of WebGLVertexArrayObjectOES: https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/createVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/deleteVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/isVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/bindVertexArrayOES Developer release notes: https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL fwiw, I don't see this changed in the spec https://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/ and Chrome seems to use WebGLVertexArrayObjectOES for this still.
You need to log in before you can comment on or make changes to this bug.