Closed Bug 1318523 Opened 4 years ago Closed 4 years ago

Unify VAO object types

Categories

(Core :: Canvas: WebGL, defect, P1)

51 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- disabled
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Keywords: dev-doc-complete, Whiteboard: gfx-noted)

Attachments

(1 file, 2 obsolete files)

We have two different webidl types right now. We should only need one.

The implementation for the WebGL 1 extension already calls into the webgl2 entrypoints, so that part is already unified.
Comment on attachment 8812004 [details]
Bug 1318523 - Unify VAO implementation. -

https://reviewboard.mozilla.org/r/93888/#review94112
Attachment #8812004 - Flags: review?(ethlin) → review+
Comment on attachment 8812003 [details]
Bug 1318523 - Remove removed class from test_interfaces. -

https://reviewboard.mozilla.org/r/93886/#review94244
Attachment #8812003 - Flags: review?(kyle) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7daa2b41dae
Remove removed class from test_interfaces. - r=qdot CLOSED TREE
Attachment #8812004 - Attachment is obsolete: true
Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8818745 - Flags: review+
Attachment #8818745 - Flags: approval-mozilla-beta?
Attachment #8818745 - Flags: approval-mozilla-aurora?
Attachment #8812003 - Attachment is obsolete: true
Comment on attachment 8818745 [details]
placeholder for all patches

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.
Attachment #8818745 - Flags: approval-mozilla-beta?
Attachment #8818745 - Flags: approval-mozilla-beta+
Attachment #8818745 - Flags: approval-mozilla-aurora?
Attachment #8818745 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.