1318523 - Unify VAO object types

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

We have two different webidl types right now. We should only need one.

The implementation for the WebGL 1 extension already calls into the webgl2 entrypoints, so that part is already unified.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318523 - Remove removed class from test_interfaces. -

Review commit: https://reviewboard.mozilla.org/r/93886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93886/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318523 - Unify VAO implementation. -

Review commit: https://reviewboard.mozilla.org/r/93888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93888/

Comment 3

[Ethan Lin[:ethlin]]

Comment on attachment 8812004 [details]
Bug 1318523 - Unify VAO implementation. -

https://reviewboard.mozilla.org/r/93888/#review94112

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8812003 [details]
Bug 1318523 - Remove removed class from test_interfaces. -

https://reviewboard.mozilla.org/r/93886/#review94244

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4efff3270cc
Unify VAO idl. - r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/e63177dc8159
Unify VAO implementation. - r=ethlin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7daa2b41dae
Remove removed class from test_interfaces. - r=qdot CLOSED TREE

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8812003 [details]
Bug 1318523 - Remove removed class from test_interfaces. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93886/diff/1-2/

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a4efff3270cc
https://hg.mozilla.org/mozilla-central/rev/e63177dc8159
https://hg.mozilla.org/mozilla-central/rev/d7daa2b41dae

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: placeholder for all patches

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8818745 [details]
placeholder for all patches

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/862d2138d2cb
https://hg.mozilla.org/releases/mozilla-aurora/rev/979b0d825099
https://hg.mozilla.org/releases/mozilla-aurora/rev/39a2b1903eb3

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/20f13465735a
https://hg.mozilla.org/releases/mozilla-beta/rev/7a08e435f8c8
https://hg.mozilla.org/releases/mozilla-beta/rev/519df7a15978

Comment 13

[Florian Scholz (Open Web Docs)]

Redirected https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObjectOES to https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObject

Updated reference docs to mention WebGLVertexArrayObject instead of WebGLVertexArrayObjectOES:
https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object
https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/createVertexArrayOES
https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/deleteVertexArrayOES
https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/isVertexArrayOES
https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/bindVertexArrayOES

Developer release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL

fwiw, I don't see this changed in the spec https://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/ and Chrome seems to use WebGLVertexArrayObjectOES for this still.