Closed
Bug 1318523
Opened 7 years ago
Closed 7 years ago
Unify VAO object types
Categories
(Core :: Graphics: CanvasWebGL, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
(Keywords: dev-doc-complete, Whiteboard: gfx-noted)
Attachments
(1 file, 2 obsolete files)
11 bytes,
text/plain
|
jgilbert
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details |
We have two different webidl types right now. We should only need one. The implementation for the WebGL 1 extension already calls into the webgl2 entrypoints, so that part is already unified.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8812004 [details] Bug 1318523 - Unify VAO implementation. - https://reviewboard.mozilla.org/r/93888/#review94112
Attachment #8812004 -
Flags: review?(ethlin) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8812003 [details] Bug 1318523 - Remove removed class from test_interfaces. - https://reviewboard.mozilla.org/r/93886/#review94244
Attachment #8812003 -
Flags: review?(kyle) → review+
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a4efff3270cc Unify VAO idl. - r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/e63177dc8159 Unify VAO implementation. - r=ethlin
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7daa2b41dae Remove removed class from test_interfaces. - r=qdot CLOSED TREE
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8812004 -
Attachment is obsolete: true
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a4efff3270cc https://hg.mozilla.org/mozilla-central/rev/e63177dc8159 https://hg.mozilla.org/mozilla-central/rev/d7daa2b41dae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 9•7 years ago
|
||
Approval Request Comment [Feature/Bug causing the regression]: webgl2 [User impact if declined]: [Is this code covered by automated tests?]: [Has the fix been verified in Nightly?]: [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: [Is the change risky?]: [Why is the change risky/not risky?]: [String changes made/needed]:
Attachment #8818745 -
Flags: review+
Attachment #8818745 -
Flags: approval-mozilla-beta?
Attachment #8818745 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•7 years ago
|
Attachment #8812003 -
Attachment is obsolete: true
Comment 10•7 years ago
|
||
Comment on attachment 8818745 [details]
placeholder for all patches
WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.
Attachment #8818745 -
Flags: approval-mozilla-beta?
Attachment #8818745 -
Flags: approval-mozilla-beta+
Attachment #8818745 -
Flags: approval-mozilla-aurora?
Attachment #8818745 -
Flags: approval-mozilla-aurora+
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/862d2138d2cb https://hg.mozilla.org/releases/mozilla-aurora/rev/979b0d825099 https://hg.mozilla.org/releases/mozilla-aurora/rev/39a2b1903eb3
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/20f13465735a https://hg.mozilla.org/releases/mozilla-beta/rev/7a08e435f8c8 https://hg.mozilla.org/releases/mozilla-beta/rev/519df7a15978
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 13•7 years ago
|
||
Redirected https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObjectOES to https://developer.mozilla.org/en-US/docs/Web/API/WebGLVertexArrayObject Updated reference docs to mention WebGLVertexArrayObject instead of WebGLVertexArrayObjectOES: https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/createVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/deleteVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/isVertexArrayOES https://developer.mozilla.org/en-US/docs/Web/API/OES_vertex_array_object/bindVertexArrayOES Developer release notes: https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL fwiw, I don't see this changed in the spec https://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/ and Chrome seems to use WebGLVertexArrayObjectOES for this still.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•