All users were logged out of Bugzilla on October 13th, 2018

update tooltool rustc to 1.14.0-beta.2

RESOLVED FIXED in Firefox 53

Status

RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

unspecified
mozilla53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments)

Update builders to rustc 1.14.0-beta.2

This beta release has a fix for the arm codegen issue with 1.13.0-stable, allowing us to use 1.13 language features everywhere. 1.14.0 will be in stable release before Firefox 53 goes to Aurora so the beta toolchain will only apply for part of the nightly phase.
(Assignee)

Comment 1

2 years ago
repack of upstream builds:
rustc 1.14.0-beta.2 (e627a2e6e 2016-11-16)
cargo 0.15.0-nightly (a9c23dd 2016-11-15)

[
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-i686-pc-windows-msvc-repack.tar.bz2",
"unpack": true,
"digest": "d3a43d755a9819029421ef7f0f2997f79d4e327b38715878e097b633f858e7fb36882eef19ca59751487cef89692f8d082babf1b8196342e75bfe6b1ad9d8e7f",
"size": 64146480
},
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-x86_64-apple-darwin-repack.tar.bz2",
"unpack": true,
"digest": "638f16d1cb49e33e8a26d4e64370aaecac02bc3db24c362bb28be347ad5501eaff266e406a1c006f59d46eacddc6b977791c2c019c9bd5f44c3ee6b1523f0b79",
"size": 118129675
},
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-x86_64-pc-windows-msvc-repack.tar.bz2",
"unpack": true,
"digest": "9eb86b4345f974470efbaddadf9f462af019be3ea4318471eea3c6dbe6e4c2108af7c6d6130b396ecb6550aa105ab8102dfa85b8964ebc1611061e485581cbf3",
"size": 69780370
},
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-x86_64-unknown-linux-gnu-android-cross-repack.tar.xz",
"unpack": true,
"digest": "6f9f6c5fde5366fe7c67f9a7699b8c64c2e14940d57e9cf87026b61a9cbf4aabe0d35933c1365034980031164817fd51c3bc02d6449bd9e8f2225981b053e47e",
"size": 96360828
},
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-x86_64-unknown-linux-gnu-mac-cross-repack.tar.xz",
"unpack": true,
"digest": "951653b08e68f89c1f9ebc236f1f91dee18d30bdc53e374bd55beacd5a67cc545e95bd1655d3c8d9a473513aaaec2281952f16585e8ed34a734ee6517ac17e49",
"size": 152410204
},
{
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc-x86_64-unknown-linux-gnu-repack.tar.xz",
"unpack": true,
"digest": "26c11e34df81f5d7ffafc3492df9c6821f644a2e2eda5cfbbcdb1ac23e4ee196007b417c862c60a97bbf66e4be9c801400990938cd3aefec19b1cf9eaf1a9b54",
"size": 96275316
}
]
Why?
To turn on --enable-rust support for Android quickly, thereby being able to default to --enable-rust?
And why exactly can't we do that with the version that's currently used, which is 1.12 on android and 1.13 elsewhere? And if we really want >= 1.13, why do we want to update across all platforms to work around 1.13's problems on arm, instead of only updating for android builds?
Using 1.14 beta would also fix bug 1311458, which is pretty important for crash reporting.
Blocks: 1311458
(Assignee)

Comment 6

2 years ago
(In reply to Mike Hommey [:glandium] from comment #4)

> And if we really want >= 1.13, why do we want to update across all
> platforms to work around 1.13's problems on arm, instead of only
> updating for android builds?

Sorry I failed to mention the debuginfo motivation. I think improving our crash reporting is worth the additional risk of building nightly with the beta toolchain.
Blocks: 1316696
Yeah, it'd be great to land this, if possible. There are a bunch of bugs around crash reporting that are waiting on this to see if it changes the experience:
https://bugzilla.mozilla.org/showdependencytree.cgi?id=1268328&hide_resolved=1
(Assignee)

Updated

2 years ago
Assignee: nobody → giles
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Mac builds failed on try because the cargo binary dynamically links homebrew's openssl in /usr/local/opt/openssl which the builders don't have. I filed https://github.com/rust-lang/cargo/issues/3320 to address that. In the meantime I'll remove the Mac bump from the patch in the interest of landing this for the other platforms.

Comment 12

2 years ago
mozreview-review
Comment on attachment 8813451 [details]
Bug 1318531 - Fix whitespace in tooltool manifests.

https://reviewboard.mozilla.org/r/94850/#review95292
Attachment #8813451 - Flags: review?(mshal) → review+

Comment 13

2 years ago
mozreview-review
Comment on attachment 8813676 [details]
Bug 1318531 - Update builders to rust 1.14.0-beta.2.

https://reviewboard.mozilla.org/r/95082/#review95294

r+ assuming the mac parts are removed.
Attachment #8813676 - Flags: review?(mshal) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Thanks. Removed mac bump; carrying forward r=mshal.

Comment 17

2 years ago
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2dc827ea437a
Fix whitespace in tooltool manifests. r=mshal
https://hg.mozilla.org/integration/autoland/rev/6a1039fa088f
Update builders to rust 1.14.0-beta.2. r=mshal

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2dc827ea437a
https://hg.mozilla.org/mozilla-central/rev/6a1039fa088f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.