1318550 - [AS] [Telemetry] Track sync status of highlight and top site items

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Grisha Kruglov]

We'd like to know what percentage of interactions with "highlights" are happenings with items that were already synced.

If user doesn't have Sync enabled, none of the items in highlights would have been synced - unless user had sync enabled and then disabled it.

If user has Sync enabled, and they're syncing history/bookmarks, items in highlights will have been synced, unless they haven't been synced yet (new visits, or sync didn't run in a while for some reason).

Either way, it seems that to make sense of "synced/not synced" data point, we also need an additional "sync is enabled for history" or "sync is enabled for bookmarks" flags.

Comment 1

[:Grisha Kruglov]

After actually considering our schema, I'm not sure this is feasible as described without changes to sync.

At best, we can say that a history item in highlights has only been visited locally, or it has only been visited remotely, or it's been visited both locally and remotely. For top sites, we currently excluded "only visited remotely" items, so it'll be just "visited only locally, or visited both locally and remotely".

Interacting with items that haven't been visited locally up to this point could be pretty interesting when considering highlights. We'll be able to see if people are interacting with pages they've visited on a desktop and that algorithm surfaced up, and perhaps compare that with those that were also visited locally.

Engineering-wise, it should not be difficult to implement as described:
- add additional telemetry flag for highlight interactions to indicate if highlight is 1) local, 2) remote, 3) mixed.

Comment 2

[:Grisha Kruglov]

Attachment: Bug 1318550 - Track "visits state" for all highlight interactions

Adds tracking of what type of visits a highlight which is being interacted with
presently has.

Possible types of visits:
- none, a default bookmark that user never opened being displayed as a highlight
- local only, user only ever visited this URL on their current device
- remote only, user never visited this URL on their current device, only on other device(s)
- mixed, user visited this URL both on their current device and on other devices

Definition of "device" should be interpreted loosely. For example, it's possible that user re-installs
Firefox on the same device, connects to Sync, and we'll count all highlights as "only remotely visited".

Review commit: https://reviewboard.mozilla.org/r/108600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108600/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8832257 [details]
Bug 1318550 - Track "visits state" for all highlight interactions

https://reviewboard.mozilla.org/r/108600/#review110242

LGTM. We just need to adapt it to the changes in bug 1312016. :)

::: mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java:1196
(Diff revision 1)
> +                "CASE " +
> +                    "WHEN " + DBUtils.qualifyColumn(History.TABLE_NAME, History.VISITS) + " IS NULL THEN " + Highlights.VISITS_NONE + " " +
> +                    "WHEN " + DBUtils.qualifyColumn(History.TABLE_NAME, History.REMOTE_VISITS) + " = 0 THEN " + Highlights.VISITS_LOCAL_ONLY + " " +
> +                    "WHEN " + DBUtils.qualifyColumn(History.TABLE_NAME, History.LOCAL_VISITS) + " = 0 THEN " + Highlights.VISITS_REMOTE_ONLY + " " +
> +                    "ELSE " + Highlights.VISITS_MIXED + " END " +
> +                "AS " + Highlights.VISITS_STATE + ", " +

This query doesn't exist anymore once bug 1312016 lands. We need to move this to the new query for picking highlights candidates.

Comment 4

[:Grisha Kruglov]

Now that Bug 1312016 landed, this can be re-addressed.