1318560 - Intermittent testBug1217581 | java-exception java.lang.ArrayIndexOutOfBoundsException: length=386; index=386 at android.support.v7.graphics.ColorCutQuantizer$Vbox.fitBox(Unknown Source)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=39367800&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/S6ePOmd6Rvm6Fy2rjfBrQA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Geoff Brown [:gbrown]]

[task 2016-11-17T15:41:47.396265Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
[task 2016-11-17T15:41:47.396485Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): java.lang.ArrayIndexOutOfBoundsException: length=386; index=386
[task 2016-11-17T15:41:47.396702Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer$Vbox.fitBox(Unknown Source)
[task 2016-11-17T15:41:47.399454Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer$Vbox.<init>(Unknown Source)
[task 2016-11-17T15:41:47.399514Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer$Vbox.splitBox(Unknown Source)
[task 2016-11-17T15:41:47.399562Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer.splitBoxes(Unknown Source)
[task 2016-11-17T15:41:47.399608Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer.quantizePixels(Unknown Source)
[task 2016-11-17T15:41:47.399652Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.ColorCutQuantizer.<init>(Unknown Source)
[task 2016-11-17T15:41:47.399696Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at android.support.v7.graphics.Palette$Builder.generate(Unknown Source)
[task 2016-11-17T15:41:47.399743Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at org.mozilla.gecko.icons.processing.ColorProcessor.process(ColorProcessor.java:26)
[task 2016-11-17T15:41:47.399785Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at org.mozilla.gecko.icons.IconTask.processIcon(IconTask.java:147)
[task 2016-11-17T15:41:47.399827Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at org.mozilla.gecko.icons.IconTask.call(IconTask.java:62)
[task 2016-11-17T15:41:47.399893Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at org.mozilla.gecko.icons.IconTask.call(IconTask.java:24)
[task 2016-11-17T15:41:47.399943Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at java.util.concurrent.FutureTask.run(FutureTask.java:234)
[task 2016-11-17T15:41:47.399989Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
[task 2016-11-17T15:41:47.400035Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
[task 2016-11-17T15:41:47.400073Z] 15:41:47     INFO -  11-17 07:41:31.647 E/GeckoCrashHandler( 1874): 	at java.lang.Thread.run(Thread.java:841)

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Interesting. This is inside the support library. I'll have a look.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

It looks like this never happened on an actual device according to crash-stats.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

Review commit: https://reviewboard.mozilla.org/r/94406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94406/

Comment 5

[Geoff Brown [:gbrown]]

Comment on attachment 8812814 [details]
Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

https://reviewboard.mozilla.org/r/94406/#review94618

Comment 6

[Max Liu [:maliu]]

https://code.google.com/p/android/issues/detail?id=174522#c17

Here's a similar issue reported to google, seems they don't have a solution but catch the exception inside Palette.
Weird thing is the try/catch patch seems already been released into v23.1.0, and we're using newer v23.4.0.

Comment 7

[Max Liu [:maliu]]

Comment on attachment 8812814 [details]
Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

https://reviewboard.mozilla.org/r/94406/#review94812

::: mobile/android/base/java/org/mozilla/gecko/icons/processing/ColorProcessor.java:33
(Diff revision 1)
> +        try {
> -        final Palette palette = Palette.from(response.getBitmap()).generate();
> +            final Palette palette = Palette.from(response.getBitmap()).generate();
> -
> -        response.updateColor(palette.getVibrantColor(DEFAULT_COLOR));
> +            response.updateColor(palette.getVibrantColor(DEFAULT_COLOR));
> +        } catch (ArrayIndexOutOfBoundsException e) {
> +            // We saw the palette library fail with an ArrayIndexOutOfBoundsException intermittently

Maybe add the bug number in comment? Bug 1318560

Comment 8

[Max Liu [:maliu]]

Comment on attachment 8812814 [details]
Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

https://reviewboard.mozilla.org/r/94406/#review94818

Comment 9

[Max Liu [:maliu]]

Comment on attachment 8812814 [details]
Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

https://reviewboard.mozilla.org/r/94404/#review94860

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8812814 [details]
Bug 1318560 - ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94406/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e517eb303e
ColorProcessor: Handle ArrayIndexOutOfBoundsException from Palette library. r=gbrown,maliu

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/88e517eb303e

Comment 13

[Ryan VanderMeulen [:RyanVM]]

I know the intermittent crash only showed up recently, but it looks like the underlying defect might affect older versions as well? Assuming that's the case, please request uplift when you get a chance :)

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

See comment 3: I searched for it on crash-stats but I couldn't find any related stack trace. It looks like this only happened in automation / on the emulator so far.