Clean up GetTextNode into TextEditRules

RESOLVED FIXED in Firefox 53

Status

()

Core
Editor
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I don't know why we pass EditBase as paramter to call static method.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8815152 [details]
Bug 1318570 - Clean up GetTextNode into TextEditRules.

https://reviewboard.mozilla.org/r/96176/#review96344

::: editor/libeditor/TextEditRules.cpp:499
(Diff revision 1)
> +      ErrorResult rv;
> +      selNode = iter->NextNode(rv);
> +      if (!selNode) {
> +        rv.SuppressException();

Using IgnoredErrorResult can get rid of a call of SuppressException()? (I'm not sure.)
https://dxr.mozilla.org/mozilla-central/rev/8387a4ada9a5c4cab059d8fafe0f8c933e83c149/dom/bindings/ErrorResult.h#535
Attachment #8815152 - Flags: review?(masayuki) → review+

Comment 3

a year ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/466d794c37a1
Clean up GetTextNode into TextEditRules. r=masayuki

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/466d794c37a1
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.