1318570 - Clean up GetTextNode into TextEditRules

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Makoto Kato [:m_kato]]

I don't know why we pass EditBase as paramter to call static method.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1318570 - Clean up GetTextNode into TextEditRules.

EditorBase parameter of GetTextNode is unnecessary because it uses static method only.  Also, we should return nsINode to reduce QI.

Review commit: https://reviewboard.mozilla.org/r/96176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96176/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8815152 [details]
Bug 1318570 - Clean up GetTextNode into TextEditRules.

https://reviewboard.mozilla.org/r/96176/#review96344

::: editor/libeditor/TextEditRules.cpp:499
(Diff revision 1)
> +      ErrorResult rv;
> +      selNode = iter->NextNode(rv);
> +      if (!selNode) {
> +        rv.SuppressException();

Using IgnoredErrorResult can get rid of a call of SuppressException()? (I'm not sure.)
https://dxr.mozilla.org/mozilla-central/rev/8387a4ada9a5c4cab059d8fafe0f8c933e83c149/dom/bindings/ErrorResult.h#535

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/466d794c37a1
Clean up GetTextNode into TextEditRules. r=masayuki

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/466d794c37a1