1318583 - Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup_resize.js | Window height should increase (550 >= 654) -

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=39421190&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1479430888/mozilla-inbound_yosemite_r7-debug_test-mochitest-e10s-browser-chrome-4-bm106-tests1-macosx-build1202.txt.gz

Comment 1

[Intermittent Failures Robot]

5 failures in 715 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 3
* autoland: 2

Platform breakdown:
* windows7-32-vm: 3
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1318583&startday=2016-11-14&endday=2016-11-20&tree=all

Comment 2

[Intermittent Failures Robot]

19 failures in 114 pushes (0.167 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* autoland: 12
* mozilla-inbound: 7

Platform breakdown:
* windows8-64: 7
* windows7-32-vm: 5
* linux64: 4
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1318583&startday=2016-11-24&endday=2016-11-24&tree=all

Comment 3

[Kris Maglione [:kmag]]

Yes, I'm already working on it.

Comment 4

[Intermittent Failures Robot]

69 failures in 623 pushes (0.111 failures/push) were associated with this bug in the last 7 days. 

This is the #14 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-inbound: 34
* autoland: 30
* mozilla-central: 3
* try: 2

Platform breakdown:
* windows7-32-vm: 28
* windows8-64: 23
* osx-10-10: 8
* linux64: 8
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1318583&startday=2016-11-21&endday=2016-11-27&tree=all

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Kris, do ask for help if you need it, between this and bug 1318592, we are nearing the #1 intermittent failure- glad to see you are on it already.

Comment 6

[Kris Maglione [:kmag]]

(In reply to Joel Maher ( :jmaher) from comment #5)
> Kris, do ask for help if you need it, between this and bug 1318592, we are
> nearing the #1 intermittent failure- glad to see you are on it already.

I have a partial fix already. It should be finished by the end of the day. The main holdup has been having to test my changes on try, since I can't reproduce the Windows issues locally.

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1318583: Part 1 - Ignore fixed-width panel browser resizes that happened prior to reparenting.

Review commit: https://reviewboard.mozilla.org/r/96420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96420/

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1318583: Part 2 - Avoid races due to remote browser resizing round-trips.

Review commit: https://reviewboard.mozilla.org/r/96422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96422/

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1318583: Part 3 - Set minWidth and minHeight on non-fixed-width panel browsers.

Review commit: https://reviewboard.mozilla.org/r/96424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96424/

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1318583: Part 4 - Ensure the correct browser window is focused for tests that require it.

Review commit: https://reviewboard.mozilla.org/r/96426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96426/

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1318583: Part 5 - Re-enable OOP tests that were disabled due to focus issues.

Review commit: https://reviewboard.mozilla.org/r/96428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96428/

Comment 12

[Andrew Swan [:aswan]]

Comment on attachment 8815525 [details]
Bug 1318583: Part 1 - Ignore fixed-width panel browser resizes that happened prior to reparenting.

https://reviewboard.mozilla.org/r/96420/#review96628

Comment 13

[Andrew Swan [:aswan]]

Comment on attachment 8815526 [details]
Bug 1318583: Part 2 - Avoid races due to remote browser resizing round-trips.

https://reviewboard.mozilla.org/r/96422/#review96632

Comment 14

[Andrew Swan [:aswan]]

Comment on attachment 8815527 [details]
Bug 1318583: Part 3 - Set minWidth and minHeight on non-fixed-width panel browsers.

https://reviewboard.mozilla.org/r/96424/#review96634

Comment 15

[Andrew Swan [:aswan]]

Comment on attachment 8815528 [details]
Bug 1318583: Part 4 - Ensure the correct browser window is focused for tests that require it.

https://reviewboard.mozilla.org/r/96426/#review96680

::: browser/components/extensions/test/browser/browser_ext_omnibox.js:197
(Diff revision 1)
>    }
>  
>    function* testSuggestions(info) {
>      extension.sendMessage("set-synchronous", {synchronous: false});
>  
> +    /* eslint-disable mozilla/no-cpows-in-tests */

Matt landed this in a separate patch already, you can remove this.

Comment 16

[Andrew Swan [:aswan]]

Comment on attachment 8815529 [details]
Bug 1318583: Part 5 - Re-enable OOP tests that were disabled due to focus issues.

https://reviewboard.mozilla.org/r/96428/#review96682

Comment 17

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53a2e609bc8941ee98f679f1576e30e207b53d2b
Bug 1318583: Part 1 - Ignore fixed-width panel browser resizes that happened prior to reparenting. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/8db368bd5ecbc1159e4a4675f5c368f56a090df3
Bug 1318583: Part 2 - Avoid races due to remote browser resizing round-trips. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/2bd028b1ed5f8ce717bb620a0ca7a1e4f6be6670
Bug 1318583: Part 3 - Set minWidth and minHeight on non-fixed-width panel browsers. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/c258d5040f12098bfcc9c69a5215e14ffdcd79d6
Bug 1318583: Part 4 - Ensure the correct browser window is focused for tests that require it. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd396493d0409b1f35890c7047188deca5df13fb
Bug 1318583: Part 5 - Re-enable OOP tests that were disabled due to focus issues. r=aswan

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/53a2e609bc89
https://hg.mozilla.org/mozilla-central/rev/8db368bd5ecb
https://hg.mozilla.org/mozilla-central/rev/2bd028b1ed5f
https://hg.mozilla.org/mozilla-central/rev/c258d5040f12
https://hg.mozilla.org/mozilla-central/rev/fd396493d040

Comment 22

[Intermittent Failures Robot]

26 failures in 694 pushes (0.037 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 13
* autoland: 10
* mozilla-central: 3

Platform breakdown:
* windows8-64: 9
* windows7-32-vm: 9
* linux64: 4
* osx-10-10: 3
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1318583&startday=2016-11-28&endday=2016-12-04&tree=all