Intermittent toolkit/components/thumbnails/test/browser_thumbnails_bg_destroy_browser.js | Thumb browser should be destroyed after timeout. - Got [object XULElement], expected undefined

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

Tracking

({intermittent-failure})

unspecified
mozilla54
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox53 unaffected, firefox54 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(1 attachment)

(Assignee)

Comment 1

2 years ago
All failures are Linux64-debug. Other than comment 0, it looks like this started on Feb 14 with very low frequency, but spiked recently. I don't see any particular change to blame.

This fails right after a 2 second wait; I wonder if increasing the timeout would help?
Flags: needinfo?(gbrown)
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 3

2 years ago
I'm just guessing/hoping that increasing the timeout will avoid this failure. Worth a try?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05d58a011757a163eec913c9cbdcea5acde6a919
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
Attachment #8841800 - Flags: review?(adw)
Whiteboard: [stockwell needswork]
Comment on attachment 8841800 [details] [diff] [review]
increase timeout

Review of attachment 8841800 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, let's give it a shot.  Something else you could try would be to check whether the browser is destroyed but don't assert on it, and if it's not destroyed, wait a second and try again, up to some limit.  That way the test won't fail if it takes 5.1 seconds to destroy, and in the hopefully common case where it takes much less than 5 seconds, the test won't have to wait a full 5 seconds.
Attachment #8841800 - Flags: review?(adw) → review+
(Assignee)

Comment 5

2 years ago
I like the second-at-a-time idea - will do that.

Comment 6

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a10bbbacbbdf
Increase timeout in browser_thumbnails_bg_destroy_browser.js; r=adw

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a10bbbacbbdf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Assignee)

Updated

2 years ago
Whiteboard: [stockwell needswork] → [stockwell fixed]
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.