Closed Bug 1318730 Opened 3 years ago Closed 3 years ago

The ScrollInputMethod::MainThreadScrollbarTrackClick telemetry probe misses non-scrollToClick case

Categories

(Core :: Panning and Zooming, defect, P3)

47 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- wontfix
firefox53 --- fixed

People

(Reporter: botond, Assigned: botond)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

In bug 1238137 we added telemetry to record different input methods used to scroll.

One of the probes added was for clicking on the scrollbar track (outside of the thumb).

It turns out this can have one of two behaviours, depending on the platform and look-and-feel:

  - The "scroll to click" behaviour, where we scroll all the way to the point
    where the thumb is under the mouse.

  - A behaviour where we just scroll by one page in that direction.

At the time I wrote the probe, I was only aware of the "scroll to click" behaviour, and only instrumented that one (the two behaviours take different codepaths).

In this bug, I'd like to adjust the probe to cover the non-scrollToClick case as well.

Thanks Ryan for spotting this!
Comment on attachment 8812255 [details]
Bug 1318730 - Fire the ScrollInputMethod::MainThreadScrollbarTrackClick telemetry probe in the non-scrollToClick case as well.

https://reviewboard.mozilla.org/r/94070/#review94234
Attachment #8812255 - Flags: review?(bugmail) → review+
Assignee: nobody → botond
Priority: -- → P3
Whiteboard: [gfx-noted]
Version: Trunk → 47 Branch
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fc9b3fb2d5d
Fire the ScrollInputMethod::MainThreadScrollbarTrackClick telemetry probe in the non-scrollToClick case as well. r=kats
https://hg.mozilla.org/mozilla-central/rev/0fc9b3fb2d5d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.