Closed
Bug 1318739
Opened 8 years ago
Closed 8 years ago
remove DoFindInReadable from nsExceptionHandler
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We now have an overload for the simple case of finding |key| in some |string|, so we don't need this utility function anymore, which presumably dates from when said overload did not exist or was inaccessible due to library visibility, or something.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8812284 -
Flags: review?(ted)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8812284 [details] [diff] [review] remove DoFindInReadable from nsExceptionHandler Review of attachment 8812284 [details] [diff] [review]: ----------------------------------------------------------------- I think it didn't exist and I was cursing our string classes when I wrote that. Thanks!
Attachment #8812284 -
Flags: review?(ted) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/11552f8437ae remove DoFindInReadable from nsExceptionHandler; r=ted.mielczarek
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/11552f8437ae
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•