Closed Bug 1318760 Opened 3 years ago Closed 3 years ago

Drop [profile.release] section from webrender/Cargo.toml

Categories

(Core :: Graphics: WebRender, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Our in-tree copy of webrender/Cargo.toml has this [profile.release] section [1] that isn't in the upstream webrender. We added this when we were building webrender manually with |cargo build| to get better debugging. However now that the in-tree WR is built as part of gkrust, this section is ignored (as per Cargo docs [2]). And the root gkrust Cargo.toml already has those particular lines [3]. To reduce the diff to upstream WR we can drop these lines from our in-tree WR.

[1] https://hg.mozilla.org/projects/graphics/file/7366f433e57d/gfx/webrender/Cargo.toml#l44
[2] http://doc.crates.io/manifest.html#the-profile-sections
[3] https://hg.mozilla.org/projects/graphics/file/7366f433e57d/toolkit/library/rust/Cargo.toml#l34
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/b0be63daa7b5
Drop ignored [profile.release] section. r=morris?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.