Closed Bug 1318764 Opened 3 years ago Closed 3 years ago

Get rid of sync GetLookAndFeelCache, and send the cache with the GetXPCOMProcessAttributes message instead

Categories

(Core :: DOM: Content Processes, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This coalesces two sync messages into one.
See Also: → 1303096
Blocks: 1300411
Attachment #8812322 - Flags: review?(jmathies) → review?(wmccloskey)
Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

https://reviewboard.mozilla.org/r/94114/#review95062

Please note that InfallibleTArray and nsTArray are the same. I'm not sure which one is preferred now. Maybe check with Nathan.
Attachment #8812322 - Flags: review?(wmccloskey) → review+
Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

https://reviewboard.mozilla.org/r/94114/#review95068

::: dom/ipc/ContentChild.h:634
(Diff revision 1)
>    InfallibleTArray<mozilla::dom::FontFamilyListEntry>&
>    SystemFontFamilyList() {
>      return mFontFamilies;
>    }
>  
> +  InfallibleTArray<LookAndFeelInt>&

Thanks!

Ah, according to froydnj, nsTArray is preferred over InfallibleTArray. I'll update the patch with that change before landing.
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fec5699c5c50
Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead. r=billm
https://hg.mozilla.org/mozilla-central/rev/fec5699c5c50
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.