1318789 - ATMO V2: unable to create new spark job

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect)

Description

[David Durst [:ddurst]]

Attempting to create a spark job with the name "Addon analysis" and an ipynb, I hit two issues:

1) it fails to submit, complaining about the "Job indentifier" (saying "Enter a valid value.") When I enter "Addon analysis" the Job identifier goes green and says "Identifier is available."

2) When I try to click on "Schedule", I get a doorhanger-like balloon at (0,0) of my viewport that says "Please select a file", even though the file upload control said "Just uploaded file: AddonAnalysis.ipynb\nThis file will be used when the form is successfully submitted"

I assume this problem stops me from re-creating any/all ipynb-based Jobs on ATMO v2 for the time being.

Comment 1

[Jannis Leidel [:jezdez]]

To clarify the bugs found here:

1) this is an issue with the job identifier validation and availability check overlapping. The first checks if the identifier contains any characters other than characters, digits or hyphens and happens on form submission. The second happens when typing and only checks the database for existing jobs with that name.

While "Addon analysis" is an invalid identifier, it's also "available" as it hasn't been used before in the database. 
We can fix this by stripping any invalid character from the identifier on input or form submission. Or extend the identifier validation to also check for the validity.

2) This is basically a bug in the way we store files in a cache if a form submission happens and the user needs to resubmit again. When the form is rendered a second time to ask for fixing the form values we should remove the "required" attribute from the hidden (hence the "doorhanger-like balloon at (0,0)") file input.

Comment 2

[GitHub Autolander Bot]

Attachment: [telemetry-analysis-service] mozilla:bug1318789 > mozilla:master

Comment 3

[Jannis Leidel [:jezdez]]

This has been fixed in stage and will likely make it today (Monday) to prod.

Comment 4

[David Durst [:ddurst]]

So.... no spaces in identifiers?