Closed Bug 1318798 Opened 3 years ago Closed 3 years ago

Remove references to config/external/nss/target after bug 1295937 removed this target

Categories

(Thunderbird :: Build Config, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 53.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 3 obsolete files)

This is because of bug 1295937 which removed config/external/nss.
Attached patch LDAPfix.patch (obsolete) — Splinter Review
With this patch TB built and LDAP search worked.
But I'm not sure it's correct and complete.
Attached patch LDAPfix.patch v2 (obsolete) — Splinter Review
Removed all occurrencies of config/external/nss/target
Assignee: nobody → richard.marti
Attachment #8812377 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8812381 - Flags: review?(ted)
Comment on attachment 8812381 [details] [diff] [review]
LDAPfix.patch v2

This is busting Thunderbird builds on Mac and Windows (strangely not Linux). So a quick review would be much appreciated. Whoever comes first ;-)
Attachment #8812381 - Flags: review?(mh+mozilla)
Summary: No rule to make target 'config/external/nss/target', needed by 'ldap/target'. Stop. → Remove references to config/external/nss/target after bug 1295937 removed this target
Severity: normal → critical
Version: unspecified → Trunk
Comment on attachment 8812381 [details] [diff] [review]
LDAPfix.patch v2

Review of attachment 8812381 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/recurse.mk
@@ +164,5 @@
>  ifeq ($(MOZ_WIDGET_TOOLKIT),gtk3)
>  toolkit/library/target: widget/gtk/mozgtk/gtk3/target
>  endif
>  ifdef MOZ_LDAP_XPCOM
> +ldap/target: mozglue/build/target

Would it be safer to add security/target here?
(In reply to aleth [:aleth] from comment #7)
> Comment on attachment 8812381 [details] [diff] [review]
> LDAPfix.patch v2
> 
> Review of attachment 8812381 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: config/recurse.mk
> @@ +164,5 @@
> >  ifeq ($(MOZ_WIDGET_TOOLKIT),gtk3)
> >  toolkit/library/target: widget/gtk/mozgtk/gtk3/target
> >  endif
> >  ifdef MOZ_LDAP_XPCOM
> > +ldap/target: mozglue/build/target
> 
> Would it be safer to add security/target here?

Tried it with this added and building works/LDAP AB still working for me. If desired, I can add it.
I hope Ted and Mike can advise us on that. BTW, for my education, what is |security/target| ?
Comment on attachment 8812381 [details] [diff] [review]
LDAPfix.patch v2

Review of attachment 8812381 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/recurse.mk
@@ +164,5 @@
>  ifeq ($(MOZ_WIDGET_TOOLKIT),gtk3)
>  toolkit/library/target: widget/gtk/mozgtk/gtk3/target
>  endif
>  ifdef MOZ_LDAP_XPCOM
> +ldap/target: mozglue/build/target

Yes, you need to add security/target here.
Attachment #8812381 - Flags: review?(ted)
Attachment #8812381 - Flags: review?(mh+mozilla)
Attached patch LDAPFix.patch v3Splinter Review
Patch with security/target added.
Attachment #8812381 - Attachment is obsolete: true
Attachment #8812478 - Flags: review?(mh+mozilla)
Attached patch LDAPfix.patch (v3) (obsolete) — Splinter Review
Here you go ;-)
Attachment #8812479 - Flags: review?(mh+mozilla)
Comment on attachment 8812479 [details] [diff] [review]
LDAPfix.patch (v3)

Richard was faster.
Attachment #8812479 - Attachment is obsolete: true
Attachment #8812479 - Flags: review?(mh+mozilla)
Comment on attachment 8812478 [details] [diff] [review]
LDAPFix.patch v3

Review of attachment 8812478 [details] [diff] [review]:
-----------------------------------------------------------------

On the long term, it would be better if the ldap build system was transposed to moz.build or gyp, so that these dependencies are not necessary at all and changes to m-c don't break it again in the future.
Attachment #8812478 - Flags: review?(mh+mozilla) → review+
Thanks.

Aleth, can you please push this to M-I.
Flags: needinfo?(aleth)
Keywords: checkin-needed
Pushed by mozilla@kewis.ch:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f8700acec46
Remove config/external/nss/target in recurse.mk. r=ted
Keywords: checkin-needed
Flags: needinfo?(aleth)
https://hg.mozilla.org/mozilla-central/rev/9f8700acec46
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.