Closed
Bug 1318805
Opened 8 years ago
Closed 8 years ago
Move the code for the Web Painting module to layout/painting
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
This will help make it clearer that this code lives in a different module for contributors.
|
Reporter | |
Comment 1•8 years ago
|
||
Attachment #8812389 -
Flags: review?(matt.woodrow)
|
|
Reporter | |
Comment 2•8 years ago
|
||
(If you agree with the general idea, but would prefer a different directory, I'd be happy to change the patch accordingly. If you disagree with this, please r-. :-)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8812389 [details] [diff] [review] Move the code for the Web Painting module to gfx/paint Review of attachment 8812389 [details] [diff] [review]: ----------------------------------------------------------------- This is going to ruin my muscle memory for opening those files... Good idea though.
Attachment #8812389 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 4•8 years ago
|
||
Why not layout/painting?
|
|
Reporter | |
Comment 5•8 years ago
|
||
I'm ambivalent on the directory name. Should I move it under layout?
Flags: needinfo?(tnikkel)
Flags: needinfo?(matt.woodrow)
|
|
||
Comment 6•8 years ago
|
||
I don't have a strong opinion, but keeping this code under layout seems like a good idea.
Flags: needinfo?(matt.woodrow)
I tend to prefer layout/painting as well. Also, gfx/paint/moz.build is not present in the patch, but it seems like it should be.
|
|
Reporter | |
Comment 8•8 years ago
|
||
OK, I'll move this to layout/painting instead! Not sure why the moz.build file is missing from the patch, it exists in my local copy. I'll submit a new version anyway.
|
|
Reporter | |
Updated•8 years ago
|
Summary: Move the code for the Web Painting module to gfx/paint → Move the code for the Web Painting module to layout/painting
|
|
Reporter | |
Comment 9•8 years ago
|
||
This will help make it clearer that this code lives in a different module for contributors.
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8812389 -
Attachment is obsolete: true
|
||
Comment 11•8 years ago
|
||
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0eb83ca237 Move the code for the Web Painting module to layout/painting; r=mattwoodrow
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d0eb83ca237
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
Assignee | |
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•