Move the code for the Web Painting module to layout/painting

RESOLVED FIXED in Firefox 53

Status

()

Core
Layout: View Rendering
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: Away for a while, Unassigned)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
This will help make it clearer that this code lives in a different
module for contributors.
(Reporter)

Comment 1

a year ago
Created attachment 8812389 [details] [diff] [review]
Move the code for the Web Painting module to gfx/paint
Attachment #8812389 - Flags: review?(matt.woodrow)
(Reporter)

Comment 2

a year ago
(If you agree with the general idea, but would prefer a different directory, I'd be happy to change the patch accordingly.  If you disagree with this, please r-.  :-)
Comment on attachment 8812389 [details] [diff] [review]
Move the code for the Web Painting module to gfx/paint

Review of attachment 8812389 [details] [diff] [review]:
-----------------------------------------------------------------

This is going to ruin my muscle memory for opening those files... Good idea though.
Attachment #8812389 - Flags: review?(matt.woodrow) → review+
Why not layout/painting?
(Reporter)

Comment 5

a year ago
I'm ambivalent on the directory name.  Should I move it under layout?
Flags: needinfo?(tnikkel)
Flags: needinfo?(matt.woodrow)
I don't have a strong opinion, but keeping this code under layout seems like a good idea.
Flags: needinfo?(matt.woodrow)
I tend to prefer layout/painting as well.

Also, gfx/paint/moz.build is not present in the patch, but it seems like it should be.
(Reporter)

Comment 8

a year ago
OK, I'll move this to layout/painting instead!  Not sure why the moz.build file is missing from the patch, it exists in my local copy.  I'll submit a new version anyway.
(Reporter)

Updated

a year ago
Summary: Move the code for the Web Painting module to gfx/paint → Move the code for the Web Painting module to layout/painting
(Reporter)

Comment 9

a year ago
Created attachment 8812964 [details] [diff] [review]
Move the code for the Web Painting module to layout/painting

This will help make it clearer that this code lives in a different
module for contributors.
(Reporter)

Updated

a year ago
Attachment #8812389 - Attachment is obsolete: true
layout/painting sounds good to me.
Flags: needinfo?(tnikkel)

Comment 11

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0eb83ca237
Move the code for the Web Painting module to layout/painting; r=mattwoodrow

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d0eb83ca237
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.